* extraneous allocation in qemu-kvm's hw/pc_piix.c
@ 2010-10-25 17:15 Tim Pepper
0 siblings, 0 replies; 4+ messages in thread
From: Tim Pepper @ 2010-10-25 17:15 UTC (permalink / raw)
To: KVM list
While doing some source review I noticed what appears to be
an extraneous call to pc_allocate_cpu_irq() in qemu-kvm and
which does not appear in qemu. From the git history it almost
looks like b725a661eb38c93086e0b98f626a3864ae8651b8 mis-merged
845773ab03a8dde681ff1b929bbb41e67d0131a6? At any rate qemu-kvm got
patched differently than qemu for the piix split out and this line
appears to allocate something which then goes unused.
Signed-off-by: Tim Pepper <lnxninja@linux.vnet.ibm.com>
---
diff --git a/hw/pc_piix.c b/hw/pc_piix.c
index 3d07ce5..781d5ad 100644
--- a/hw/pc_piix.c
+++ b/hw/pc_piix.c
@@ -128,7 +128,6 @@ static void pc_init1(ram_addr_t ram_size,
isa_bus_irqs(isa_irq);
pc_register_ferr_irq(isa_reserve_irq(13));
- cpu_irq = pc_allocate_cpu_irq();
pc_vga_init(pci_enabled? pci_bus: NULL);
--
Tim Pepper <lnxninja@linux.vnet.ibm.com>
IBM Linux Technology Center
^ permalink raw reply related [flat|nested] 4+ messages in thread
* extraneous allocation in qemu-kvm's hw/pc_piix.c
@ 2010-10-26 17:52 Tim Pepper
2010-10-27 18:34 ` Tim Pepper
2010-11-03 12:56 ` Marcelo Tosatti
0 siblings, 2 replies; 4+ messages in thread
From: Tim Pepper @ 2010-10-26 17:52 UTC (permalink / raw)
To: kvm
While doing some source review I noticed what appears to be
an extraneous call to pc_allocate_cpu_irq() in qemu-kvm and
which does not appear in qemu. From the git history it almost
looks like b725a661eb38c93086e0b98f626a3864ae8651b8 mis-merged
845773ab03a8dde681ff1b929bbb41e67d0131a6? At any rate qemu-kvm got
patched differently than qemu for the piix split out and this line
appears to allocate something which then goes unused.
Signed-off-by: Tim Pepper <lnxninja@linux.vnet.ibm.com>
---
diff --git a/hw/pc_piix.c b/hw/pc_piix.c
index 3d07ce5..781d5ad 100644
--- a/hw/pc_piix.c
+++ b/hw/pc_piix.c
@@ -128,7 +128,6 @@ static void pc_init1(ram_addr_t ram_size,
isa_bus_irqs(isa_irq);
pc_register_ferr_irq(isa_reserve_irq(13));
- cpu_irq = pc_allocate_cpu_irq();
pc_vga_init(pci_enabled? pci_bus: NULL);
--
Tim Pepper <lnxninja@linux.vnet.ibm.com>
IBM Linux Technology Center
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: extraneous allocation in qemu-kvm's hw/pc_piix.c
2010-10-26 17:52 extraneous allocation in qemu-kvm's hw/pc_piix.c Tim Pepper
@ 2010-10-27 18:34 ` Tim Pepper
2010-11-03 12:56 ` Marcelo Tosatti
1 sibling, 0 replies; 4+ messages in thread
From: Tim Pepper @ 2010-10-27 18:34 UTC (permalink / raw)
To: kvm
(apologies for double posting of this message...mail client fubar)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: extraneous allocation in qemu-kvm's hw/pc_piix.c
2010-10-26 17:52 extraneous allocation in qemu-kvm's hw/pc_piix.c Tim Pepper
2010-10-27 18:34 ` Tim Pepper
@ 2010-11-03 12:56 ` Marcelo Tosatti
1 sibling, 0 replies; 4+ messages in thread
From: Marcelo Tosatti @ 2010-11-03 12:56 UTC (permalink / raw)
To: Tim Pepper; +Cc: kvm
On Tue, Oct 26, 2010 at 10:52:00AM -0700, Tim Pepper wrote:
> While doing some source review I noticed what appears to be
> an extraneous call to pc_allocate_cpu_irq() in qemu-kvm and
> which does not appear in qemu. From the git history it almost
> looks like b725a661eb38c93086e0b98f626a3864ae8651b8 mis-merged
> 845773ab03a8dde681ff1b929bbb41e67d0131a6? At any rate qemu-kvm got
> patched differently than qemu for the piix split out and this line
> appears to allocate something which then goes unused.
>
> Signed-off-by: Tim Pepper <lnxninja@linux.vnet.ibm.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-11-03 13:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-26 17:52 extraneous allocation in qemu-kvm's hw/pc_piix.c Tim Pepper
2010-10-27 18:34 ` Tim Pepper
2010-11-03 12:56 ` Marcelo Tosatti
-- strict thread matches above, loose matches on Subject: below --
2010-10-25 17:15 Tim Pepper
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).