From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: extraneous allocation in qemu-kvm's hw/pc_piix.c
Date: Wed, 3 Nov 2010 10:56:11 -0200
Message-ID: <20101103125611.GC16809@amt.cnet>
References: <AANLkTi=9KqHFLJKBR+VoK3CLDRN1gheJJYJZ6crvnryf@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: kvm@vger.kernel.org
To: Tim Pepper <lnxninja@linux.vnet.ibm.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:9992 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751935Ab0KCNos (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 3 Nov 2010 09:44:48 -0400
Content-Disposition: inline
In-Reply-To: <AANLkTi=9KqHFLJKBR+VoK3CLDRN1gheJJYJZ6crvnryf@mail.gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, Oct 26, 2010 at 10:52:00AM -0700, Tim Pepper wrote:
> While doing some source review I noticed what appears to be
> an extraneous call to pc_allocate_cpu_irq() in qemu-kvm and
> which does not appear in qemu.  From the git history it almost
> looks like b725a661eb38c93086e0b98f626a3864ae8651b8 mis-merged
> 845773ab03a8dde681ff1b929bbb41e67d0131a6?  At any rate qemu-kvm got
> patched differently than qemu for the piix split out and this line
> appears to allocate something which then goes unused.
> 
> Signed-off-by: Tim Pepper <lnxninja@linux.vnet.ibm.com>

Applied, thanks.