From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luiz Capitulino Subject: Re: [PATCH -v2] Monitor command: pfa2hva, translate guest physical address to host virtual address Date: Thu, 4 Nov 2010 14:53:42 -0200 Message-ID: <20101104145342.4627dd9d@doriath> References: <1288060789.2862.336.camel@yhuang-dev> <20101101160952.GE1429@amt.cnet> <4CCF0BAB.9000304@linux.vnet.ibm.com> <1288639205.2059.34.camel@yhuang-mobile> <4CCF136D.5080307@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Huang Ying , Marcelo Tosatti , Anthony Liguori , Avi Kivity , "kvm@vger.kernel.org" , Andi Kleen , Dean Nelson To: Anthony Liguori Return-path: Received: from mx1.redhat.com ([209.132.183.28]:32194 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751457Ab0KDQx4 (ORCPT ); Thu, 4 Nov 2010 12:53:56 -0400 In-Reply-To: <4CCF136D.5080307@linux.vnet.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, 01 Nov 2010 14:22:21 -0500 Anthony Liguori wrote: > On 11/01/2010 02:20 PM, Huang Ying wrote: > > Yes. As general interface, it may not work so well, but as test > > interface, it works quite well and useful. > > > > Do we have any mechanism to add a test only interface? No. We're likely going to introduce a new namespace for that in the near future, but only for QMP. Is this command supposed to be useful for applications or is it primary designed for (human) debugging? > I'd like to see what Luiz/Markus think but definitely only a human > monitor interface and probably prefix the command with a 'x-' prefix to > indicate that it's not a supported interface. Yes, I agree on having only the human interface but I'm not sure about prexing it with 'x-'. I think new HMP commands should be declared unstable by default starting with 0.14. > The documentation should be very clear about the limitations of the > interface and the intended use-case. > > Regards, > > Anthony Liguori > > > Best Regards, > > Huang Ying > > > > > > >