public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Avi Kivity <avi@redhat.com>, kvm <kvm@vger.kernel.org>
Subject: Re: [PATCH] KVM: Fix srcu struct leakage
Date: Tue, 9 Nov 2010 11:53:50 -0200	[thread overview]
Message-ID: <20101109135350.GA25952@amt.cnet> (raw)
In-Reply-To: <4CD93366.5000209@siemens.com>

On Tue, Nov 09, 2010 at 12:41:26PM +0100, Jan Kiszka wrote:
> Clean up the srcu struct on vm destruction.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  virt/kvm/kvm_main.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c
> index 4111a4b..6ec58d1 100644
> --- a/virt/kvm/kvm_main.c
> +++ b/virt/kvm/kvm_main.c
> @@ -513,6 +513,7 @@ static void kvm_destroy_vm(struct kvm *kvm)
>  #else
>  	kvm_arch_flush_shadow(kvm);
>  #endif
> +	cleanup_srcu_struct(&kvm->srcu);
>  	kvm_arch_destroy_vm(kvm);
>  	hardware_disable_all();
>  	mmdrop(mm);
> -- 
> 1.7.1

kvm_arch_destroy_vm does it.

  parent reply	other threads:[~2010-11-09 13:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-09 11:41 [PATCH] KVM: Fix srcu struct leakage Jan Kiszka
2010-11-09 13:30 ` Avi Kivity
2010-11-09 13:53 ` Marcelo Tosatti [this message]
2010-11-09 13:59   ` Jan Kiszka
2010-11-09 14:03     ` Marcelo Tosatti
2010-11-09 14:07       ` Jan Kiszka
2010-11-09 14:30         ` Avi Kivity
2010-11-09 14:36           ` Jan Kiszka
2010-11-09 16:00             ` Avi Kivity
2010-11-09 14:05     ` Jan Kiszka
2010-11-09 14:00   ` Avi Kivity
  -- strict thread matches above, loose matches on Subject: below --
2010-11-07 12:58 Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101109135350.GA25952@amt.cnet \
    --to=mtosatti@redhat.com \
    --cc=avi@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox