Re: [RESEND PATCH] virtio-net: init link state correctly

Rusty Russell
2010-11-11T00:45:05Z

On Thu, 11 Nov 2010 01:38:23 am Michael S. Tsirkin wrote:
> On Mon, Nov 08, 2010 at 09:41:27AM +1030, Rusty Russell wrote:
> > On Fri, 5 Nov 2010 08:17:18 pm Jason Wang wrote:
> > > For device that supports VIRTIO_NET_F_STATUS, there's no need to
> > > assume the link is up and we need to call nerif_carrier_off() before
> > > querying device status, otherwise we may get wrong operstate after
> > > diver was loaded because the link watch event was not fired as
> > > expected.
> > >
> > > For device that does not support VIRITO_NET_F_STATUS, we could not get
> > > its status through virtnet_update_status() and what we can only do is
> > > always assuming the link is up.
> > >
> > > Acked-by: Michael S. Tsirkin <mst@redhat.com>
> > > Signed-off-by: Jason Wang <jasowang@redhat.com>
> >
> > Acked-by: Rusty Russell <rusty@rustcorp.com.au>
> >
> > Thanks!
> > Rusty.
>
> Rusty, just to verify: who shall be queueing this up?

Sorry, that was sloppy of me; was meant for DaveM to take.

Sending explicitly now...
Rusty.