From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH v2 1/2] KVM: SVM: Replace svm_has() by standard Linux cpuid accessors Date: Thu, 11 Nov 2010 15:46:06 +0100 Message-ID: <20101111144606.GD5193@8bytes.org> References: <1289312143-32480-1-git-send-email-avi@redhat.com> <1289312143-32480-2-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from 8bytes.org ([88.198.83.132]:44596 "EHLO 8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756830Ab0KKOqH (ORCPT ); Thu, 11 Nov 2010 09:46:07 -0500 Content-Disposition: inline In-Reply-To: <1289312143-32480-2-git-send-email-avi@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Nov 09, 2010 at 04:15:42PM +0200, Avi Kivity wrote: > - if (nr == BP_VECTOR && !svm_has(SVM_FEATURE_NRIP)) { > + if (nr == BP_VECTOR && !static_cpu_has(X86_FEATURE_NRIPS)) { What is static_cpu_has and why you use it only here and boot_cpu_has in all other places? Joerg