From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 2/3] virtio-pci: Use ioeventfd for virtqueue notify Date: Thu, 11 Nov 2010 11:45:18 -0500 Message-ID: <20101111164518.GA28773@infradead.org> References: <1289483242-6069-1-git-send-email-stefanha@linux.vnet.ibm.com> <1289483242-6069-3-git-send-email-stefanha@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, "Michael S. Tsirkin" To: Stefan Hajnoczi Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:34608 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754329Ab0KKQpW (ORCPT ); Thu, 11 Nov 2010 11:45:22 -0500 Content-Disposition: inline In-Reply-To: <1289483242-6069-3-git-send-email-stefanha@linux.vnet.ibm.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Nov 11, 2010 at 01:47:21PM +0000, Stefan Hajnoczi wrote: > Some virtio devices are known to have guest drivers which expect a notify to be > processed synchronously and spin waiting for completion. Only enable ioeventfd > for virtio-blk and virtio-net for now. Who guarantees that less common virtio-blk and virtio-net guest drivers for non-Linux OSes are fine with it? Maybe you should add a feature flag that the guest has to ACK to enable it.