From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCHv3 08/14] Add get_fw_dev_path callback for pci bus. Date: Thu, 11 Nov 2010 19:14:44 +0200 Message-ID: <20101111171444.GB30171@redhat.com> References: <1289409261-5418-1-git-send-email-gleb@redhat.com> <1289409261-5418-9-git-send-email-gleb@redhat.com> <20101110173412.GE3891@redhat.com> <4CDBC045.3070902@redhat.com> <20101111150511.GF25692@redhat.com> <20101111160753.GB7948@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Gerd Hoffmann , qemu-devel@nongnu.org, kvm@vger.kernel.org, blauwirbel@gmail.com, armbru@redhat.com, alex.williamson@redhat.com To: Gleb Natapov Return-path: Received: from mx1.redhat.com ([209.132.183.28]:43880 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754365Ab0KKROy (ORCPT ); Thu, 11 Nov 2010 12:14:54 -0500 Content-Disposition: inline In-Reply-To: <20101111160753.GB7948@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Nov 11, 2010 at 06:07:53PM +0200, Gleb Natapov wrote: > On Thu, Nov 11, 2010 at 05:05:11PM +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 11, 2010 at 11:07:01AM +0100, Gerd Hoffmann wrote: > > > On 11/10/10 18:34, Michael S. Tsirkin wrote: > > > >On Wed, Nov 10, 2010 at 07:14:15PM +0200, Gleb Natapov wrote: > > > >> > > > >>Signed-off-by: Gleb Natapov > > > > > > > >Good stuff. We should also consider using this for > > > >CLI and monitor. Some comments below. > > > > > > Oh, we already have a table to map pci classes to descriptions for > > > 'info pci'. > > > > You remind me, that one must be fixed to use names from > > pci_ids.h > > > For now I used numbers like other elements of the table. Fair enough. > If I > would do the conversion I would use convenience marcros to not have > names like PCI_CLASS_NETWORK_TOKEN_RING all over the table :) > > -- > Gleb. I'd prefer to keep it simple :) -- MST