From: David Miller <davem@davemloft.net>
To: jasowang@redhat.com
Cc: rusty@rustcorp.com.au, markmc@redhat.com,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
mst@redhat.com
Subject: Re: [V2 PATCH] virtio-net: init link state correctly
Date: Fri, 12 Nov 2010 12:25:53 -0800 (PST) [thread overview]
Message-ID: <20101112.122553.246519981.davem@davemloft.net> (raw)
In-Reply-To: <20101105025008.3277.87697.stgit@dhcp-91-158.nay.redhat.com>
From: Jason Wang <jasowang@redhat.com>
Date: Fri, 05 Nov 2010 10:50:08 +0800
> For device that supports VIRTIO_NET_F_STATUS, there's no need to
> assume the link is up and we need to call nerif_carrier_off() before
> querying device status, otherwise we may get wrong operstate after
> diver was loaded because the link watch event was not fired as
> expected.
>
> For device that does not support VIRITO_NET_F_STATUS, we could not get
> its status through virtnet_update_status() and what we can only do is
> always assuming the link is up.
>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
I've applied Rusty's submission of this patch which has Michael T.'s
ACK, etc.
prev parent reply other threads:[~2010-11-12 20:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-05 2:50 [V2 PATCH] virtio-net: init link state correctly Jason Wang
2010-11-05 3:00 ` Jason Wang
2010-11-05 8:47 ` Michael S. Tsirkin
2010-11-05 8:45 ` Michael S. Tsirkin
2010-11-12 20:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101112.122553.246519981.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markmc@redhat.com \
--cc=mst@redhat.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox