From: Chris Wright <chrisw@sous-sol.org>
To: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Chris Wright <chrisw@sous-sol.org>,
Jes.Sorensen@redhat.com, "Hao, Xudong" <xudong.hao@intel.com>,
Blue Swirl <blauwirbel@gmail.com>,
mohan@in.ibm.com, Avi Kivity <avi@redhat.com>
Subject: Re: [PATCH v3] virtio-9p: fix build on !CONFIG_UTIMENSAT
Date: Sun, 14 Nov 2010 19:36:50 -0800 [thread overview]
Message-ID: <20101115033650.GA24803@sequoia.sous-sol.org> (raw)
In-Reply-To: <4CE097C4.3070700@jp.fujitsu.com>
* Hidetoshi Seto (seto.hidetoshi@jp.fujitsu.com) wrote:
> This patch introduce a fallback mechanism for old systems that do not
> support utimensat(). This fix build failure with following warnings:
>
> hw/virtio-9p-local.c: In function 'local_utimensat':
> hw/virtio-9p-local.c:479: warning: implicit declaration of function 'utimensat'
> hw/virtio-9p-local.c:479: warning: nested extern declaration of 'utimensat'
>
> and:
>
> hw/virtio-9p.c: In function 'v9fs_setattr_post_chmod':
> hw/virtio-9p.c:1410: error: 'UTIME_NOW' undeclared (first use in this function)
> hw/virtio-9p.c:1410: error: (Each undeclared identifier is reported only once
> hw/virtio-9p.c:1410: error: for each function it appears in.)
> hw/virtio-9p.c:1413: error: 'UTIME_OMIT' undeclared (first use in this function)
> hw/virtio-9p.c: In function 'v9fs_wstat_post_chmod':
> hw/virtio-9p.c:2905: error: 'UTIME_OMIT' undeclared (first use in this function)
>
> v3:
> - Use better alternative handling for UTIME_NOW/OMIT
> - Move qemu_utimensat() to cutils.c
> V2:
> - Introduce qemu_utimensat()
>
> Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Looks good to me (no strong opinion on the cutils vs oslib-posix that
Jes mentioned).
Acked-by: Chris Wright <chrisw@sous-sol.org>
next prev parent reply other threads:[~2010-11-15 3:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BC00F5384FCFC9499AF06F92E8B78A9E1AC3EFA17E@shsmsx502.ccr.corp.intel.com>
2010-10-13 8:00 ` [Qemu-devel] qemu-kvm build issue on RHEL5.1 Hidetoshi Seto
2010-10-13 8:13 ` Hao, Xudong
2010-10-13 19:11 ` Blue Swirl
2010-10-14 0:33 ` Hidetoshi Seto
2010-11-04 17:03 ` Chris Wright
2010-11-05 6:32 ` Hidetoshi Seto
2010-11-05 6:32 ` [PATCH] virtio-9p: fix build on !CONFIG_UTIMENSAT v2 Hidetoshi Seto
2010-11-08 6:44 ` [Qemu-devel] " M. Mohan Kumar
2010-11-12 12:33 ` Jes Sorensen
2010-11-14 5:58 ` Chris Wright
2010-11-15 2:10 ` [Qemu-devel] " Hidetoshi Seto
2010-11-15 2:15 ` [PATCH v3] virtio-9p: fix build on !CONFIG_UTIMENSAT Hidetoshi Seto
2010-11-15 3:36 ` Chris Wright [this message]
2010-11-15 16:49 ` M. Mohan Kumar
2010-11-21 15:22 ` [Qemu-devel] " Anthony Liguori
2010-11-22 6:28 ` Jes Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101115033650.GA24803@sequoia.sous-sol.org \
--to=chrisw@sous-sol.org \
--cc=Jes.Sorensen@redhat.com \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=mohan@in.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=xudong.hao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox