From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCHv4 13/15] Add bootindex for option roms.
Date: Mon, 15 Nov 2010 12:18:17 +0200
Message-ID: <20101115101817.GJ7948@redhat.com>
References: <1289749181-12070-1-git-send-email-gleb@redhat.com>
 <1289749181-12070-14-git-send-email-gleb@redhat.com>
 <AANLkTimJ0xi6-Uu8k-T-C8OKLkHeiAPHP_1HZ28A9Bc7@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, armbru@redhat.com,
	alex.williamson@redhat.com, mst@redhat.com, kevin@koconnor.net
To: Blue Swirl <blauwirbel@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:16102 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753181Ab0KOKSX (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 15 Nov 2010 05:18:23 -0500
Content-Disposition: inline
In-Reply-To: <AANLkTimJ0xi6-Uu8k-T-C8OKLkHeiAPHP_1HZ28A9Bc7@mail.gmail.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Sun, Nov 14, 2010 at 09:33:06PM +0000, Blue Swirl wrote:
> On Sun, Nov 14, 2010 at 3:39 PM, Gleb Natapov <gleb@redhat.com> wrote:
> > Extend -option-rom command to have additional parameter ,bootindex=.
> 
> This patch is broken:
>   CC    arm-softmmu/palm.o
> /src/qemu/hw/palm.c: In function 'palmte_init':
> /src/qemu/hw/palm.c:237: error: incompatible type for argument 1 of
> 'get_image_size'
> /src/qemu/hw/palm.c:245: error: incompatible type for argument 1 of
> 'load_image_targphys'
> cc1: warnings being treated as errors
> /src/qemu/hw/palm.c:250: error: format '%s' expects type 'char *', but
> argument 4 has type 'QEMUOptionRom'
>   CC    arm-softmmu/nseries.o
> /src/qemu/hw/nseries.c: In function 'n8x0_init':
> /src/qemu/hw/nseries.c:1346: error: incompatible type for argument 1
> of 'load_image_targphys'
Fixed in new version.

--
			Gleb.