From mboxrd@z Thu Jan  1 00:00:00 1970
From: "M. Mohan Kumar" <mohan@in.ibm.com>
Subject: Re: [PATCH v3] virtio-9p: fix build on !CONFIG_UTIMENSAT
Date: Mon, 15 Nov 2010 22:19:36 +0530
Message-ID: <201011152219.36635.mohan@in.ibm.com>
References: <BC00F5384FCFC9499AF06F92E8B78A9E1AC3EFA17E@shsmsx502.ccr.corp.intel.com> <4CE0969D.5070703@jp.fujitsu.com> <4CE097C4.3070700@jp.fujitsu.com>
Mime-Version: 1.0
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	Chris Wright <chrisw@sous-sol.org>, Jes.Sorensen@redhat.com,
	"Hao, Xudong" <xudong.hao@intel.com>,
	Blue Swirl <blauwirbel@gmail.com>, Avi Kivity <avi@redhat.com>
To: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from e23smtp03.au.ibm.com ([202.81.31.145]:52244 "EHLO
	e23smtp03.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932499Ab0KOQtn (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 15 Nov 2010 11:49:43 -0500
Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [202.81.31.246])
	by e23smtp03.au.ibm.com (8.14.4/8.13.1) with ESMTP id oAFGjXQu011344
	for <kvm@vger.kernel.org>; Tue, 16 Nov 2010 03:45:33 +1100
Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96])
	by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id oAFGnfvL2129938
	for <kvm@vger.kernel.org>; Tue, 16 Nov 2010 03:49:41 +1100
Received: from d23av01.au.ibm.com (loopback [127.0.0.1])
	by d23av01.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id oAFGneJd012004
	for <kvm@vger.kernel.org>; Tue, 16 Nov 2010 03:49:41 +1100
In-Reply-To: <4CE097C4.3070700@jp.fujitsu.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

> This patch introduce a fallback mechanism for old systems that do not
> support utimensat().  This fix build failure with following warnings:
> 
> hw/virtio-9p-local.c: In function 'local_utimensat':
> hw/virtio-9p-local.c:479: warning: implicit declaration of function
> 'utimensat' hw/virtio-9p-local.c:479: warning: nested extern declaration
> of 'utimensat'
> 
> and:
> 
> hw/virtio-9p.c: In function 'v9fs_setattr_post_chmod':
> hw/virtio-9p.c:1410: error: 'UTIME_NOW' undeclared (first use in this
> function) hw/virtio-9p.c:1410: error: (Each undeclared identifier is
> reported only once hw/virtio-9p.c:1410: error: for each function it
> appears in.)
> hw/virtio-9p.c:1413: error: 'UTIME_OMIT' undeclared (first use in this
> function) hw/virtio-9p.c: In function 'v9fs_wstat_post_chmod':
> hw/virtio-9p.c:2905: error: 'UTIME_OMIT' undeclared (first use in this
> function)
> 
> v3:
>   - Use better alternative handling for UTIME_NOW/OMIT
>   - Move qemu_utimensat() to cutils.c
> V2:
>   - Introduce qemu_utimensat()
> 
> Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>

Looks good to me.

Acked-by: M. Mohan Kumar <mohan@in.ibm.com>