From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [Qemu-devel] [PATCHv5 01/15] Introduce fw_name field to
 DeviceInfo structure.
Date: Tue, 16 Nov 2010 10:59:25 +0200
Message-ID: <20101116085925.GQ7948@redhat.com>
References: <1289831469-25540-1-git-send-email-gleb@redhat.com>
 <1289831469-25540-2-git-send-email-gleb@redhat.com>
 <20101116080935.GB23139@valinux.co.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, mst@redhat.com,
	armbru@redhat.com, blauwirbel@gmail.com,
	alex.williamson@redhat.com, kevin@koconnor.net
To: Isaku Yamahata <yamahata@valinux.co.jp>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:54885 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932427Ab0KPI7d (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 16 Nov 2010 03:59:33 -0500
Content-Disposition: inline
In-Reply-To: <20101116080935.GB23139@valinux.co.jp>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, Nov 16, 2010 at 05:09:35PM +0900, Isaku Yamahata wrote:
> On Mon, Nov 15, 2010 at 04:30:55PM +0200, Gleb Natapov wrote:
> > diff --git a/hw/piix_pci.c b/hw/piix_pci.c
> > index b5589b9..38f9d9e 100644
> > --- a/hw/piix_pci.c
> > +++ b/hw/piix_pci.c
> > @@ -365,6 +365,7 @@ static PCIDeviceInfo i440fx_info[] = {
> >  static SysBusDeviceInfo i440fx_pcihost_info = {
> >      .init         = i440fx_pcihost_initfn,
> >      .qdev.name    = "i440FX-pcihost",
> > +    .qdev.fw_name = "pci",
> >      .qdev.size    = sizeof(I440FXState),
> >      .qdev.no_user = 1,
> >  };
> 
> There are other pci host bridges for not pc architecture
> which needs similar modification.
Yes, I know. This patch doesn't try to add fw_name everywhere it is
needed, just for x86 for now. Things can be added incrementally.

> Please grep by pci_register_bus().
> - apb_pci.c
> - bonito.c
> - grackle_pci.c
> - unin_pci.c
> - versatile_pci.c
I'll look into using BusInfo->name if fw_name is not available. Then all
pci buses will work.

> 
> BTW, what happens for non-qdevfied pci host bridge?
They should be converted someday.

--
			Gleb.