From: Marcelo Tosatti <mtosatti@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: VMX: Fix host userspace gsbase corruption
Date: Tue, 16 Nov 2010 18:07:35 -0200 [thread overview]
Message-ID: <20101116200735.GA23712@amt.cnet> (raw)
In-Reply-To: <1289471846-2055-1-git-send-email-avi@redhat.com>
On Thu, Nov 11, 2010 at 12:37:26PM +0200, Avi Kivity wrote:
> We now use load_gs_index() to load gs safely; unfortunately this also
> changes MSR_KERNEL_GS_BASE, which we managed separately. This resulted
> in confusion and breakage running 32-bit host userspace on a 64-bit kernel.
>
> Fix by
> - saving guest MSR_KERNEL_GS_BASE before we we reload the host's gs
> - doing the host save/load unconditionally, instead of only when in guest
> long mode
>
> Things can be cleaned up further, but this is the minmal fix for now.
>
> Signed-off-by: Avi Kivity <avi@redhat.com>
> ---
> arch/x86/kvm/vmx.c | 15 +++++++--------
> 1 files changed, 7 insertions(+), 8 deletions(-)
Applied, thanks.
prev parent reply other threads:[~2010-11-16 20:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-11 10:37 [PATCH] KVM: VMX: Fix host userspace gsbase corruption Avi Kivity
2010-11-16 20:07 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101116200735.GA23712@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox