From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH 6/6] KVM: assigned dev: MSI-X mask support
Date: Wed, 17 Nov 2010 11:35:12 -0200
Message-ID: <20101117133512.GA10322@amt.cnet>
References: <1289812532-3227-1-git-send-email-sheng@linux.intel.com>
 <1289812532-3227-7-git-send-email-sheng@linux.intel.com>
 <20101116194522.GA22758@amt.cnet>
 <201011170929.23005.sheng@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Avi Kivity <avi@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>,
	kvm@vger.kernel.org
To: Sheng Yang <sheng@linux.intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:40342 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S934108Ab0KQNhY (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 17 Nov 2010 08:37:24 -0500
Content-Disposition: inline
In-Reply-To: <201011170929.23005.sheng@linux.intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, Nov 17, 2010 at 09:29:22AM +0800, Sheng Yang wrote:
> > > +			adev->msix_mask_bitmap);
> > > +	memcpy(val, &entry[addr % PCI_MSIX_ENTRY_SIZE / sizeof *entry], len);
> > 
> > Division by zero?
> 
> Not quite understand. You mean sizeof *entry or PCI_MSIX_ENTRY_SIZE? Both of them 
> should be positive integer I think... Maybe I should use sizeof u32 here?

You're right, nevermind.