From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [PATCH 6/6] KVM: assigned dev: MSI-X mask support
Date: Thu, 18 Nov 2010 11:43:03 +0200
Message-ID: <20101118094303.GK16832@redhat.com>
References: <1289812532-3227-1-git-send-email-sheng@linux.intel.com>
 <1289812532-3227-7-git-send-email-sheng@linux.intel.com>
 <20101116194522.GA22758@amt.cnet>
 <201011170929.23005.sheng@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Marcelo Tosatti <mtosatti@redhat.com>, Avi Kivity <avi@redhat.com>,
	kvm@vger.kernel.org
To: Sheng Yang <sheng@linux.intel.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:25976 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1756147Ab0KRJnN (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 18 Nov 2010 04:43:13 -0500
Content-Disposition: inline
In-Reply-To: <201011170929.23005.sheng@linux.intel.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Wed, Nov 17, 2010 at 09:29:22AM +0800, Sheng Yang wrote:
> > > +#define KVM_MSIX_TYPE_ASSIGNED_DEV	1
> > > +
> > > +#define KVM_MSIX_FLAG_MASKBIT		(1 << 0)
> > > +#define KVM_MSIX_FLAG_QUERY_MASKBIT	(1 << 0)
> > > +
> > > +struct kvm_msix_entry {
> > > +	__u32 id;
> > > +	__u32 type;
> > 
> > Is type really necessary? Will it ever differ from
> > KVM_MSIX_TYPE_ASSIGNED_DEV?
> 
> This is the suggestion from Michael. He want it to be reused by emulated/pv 
> devices. So I add the type field here.

Maybe id field can be reused for this somehow.

-- 
MST