Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

Avi Kivity
2010-11-29T09:30:53Z

On 11/28/2010 04:49 PM, Michael S. Tsirkin wrote:
> On Sun, Nov 28, 2010 at 03:15:52PM +0200, Avi Kivity wrote:
> > On 11/28/2010 01:49 PM, Michael S. Tsirkin wrote:
> > >> +++ b/api/kvmxx.cc
> > >> @@ -0,0 +1,168 @@
> > >> +#include "kvmxx.h"
> > >> +#include<fcntl.h>
> > >> +#include<sys/ioctl.h>
> > >> +#include<sys/mman.h>
> > >
> > >I just realized this is wrong: I think you should wrap
> > >the headers in extern "C". Same for other headers.
> >
> > I think system headers already do this
> > (otherwise it won't link -
> > int foo() is different than extern "C" { int foo(void); })
>
> okay, but they aren't there for linux/kvm.h, are they?

I don't think they are needed - they only declare structures and
constants, not functions.

--
error compiling committee.c: too many arguments to function