[PATCH] virt: kvm: coding style cleanups

[PATCH] virt: kvm: coding style cleanups

[Javier Martinez Canillas]

Fixes coding style issues on virt/kvm/assigned-dev.c

Signed-off-by: Javier Martinez Canillas <martinez.javier@gmail.com>
---
 virt/kvm/assigned-dev.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/virt/kvm/assigned-dev.c b/virt/kvm/assigned-dev.c
index ae72ae6..c9dd690 100644
--- a/virt/kvm/assigned-dev.c
+++ b/virt/kvm/assigned-dev.c
@@ -620,7 +620,7 @@ static int kvm_vm_ioctl_set_msix_nr(struct kvm *kvm,
 			goto msix_nr_out;
 		}
 		adev->guest_msix_entries =
-			kzalloc(sizeof(struct msix_entry) * entry_nr->entry_nr,
+			kzalloc(sizeof(struct msix_entry) *entry_nr->entry_nr,
 				GFP_KERNEL);
 		if (!adev->guest_msix_entries) {
 			kfree(adev->host_msix_entries);
@@ -750,7 +750,7 @@ long kvm_vm_ioctl_assigned_device(struct kvm *kvm, unsigned ioctl,
 			goto out_free_irq_routing;
 		r = kvm_set_irq_routing(kvm, entries, routing.nr,
 					routing.flags);
-	out_free_irq_routing:
+out_free_irq_routing:
 		vfree(entries);
 		break;
 	}
-- 
1.7.0.4

Re: [PATCH] virt: kvm: coding style cleanups

[Dan Carpenter]

On Thu, Nov 25, 2010 at 01:28:57AM +0100, Javier Martinez Canillas wrote:
>  		adev->guest_msix_entries =
> -			kzalloc(sizeof(struct msix_entry) * entry_nr->entry_nr,
> +			kzalloc(sizeof(struct msix_entry) *entry_nr->entry_nr,

The original code was right and the new code is wrong.

>  				GFP_KERNEL);
>  		if (!adev->guest_msix_entries) {
>  			kfree(adev->host_msix_entries);
> @@ -750,7 +750,7 @@ long kvm_vm_ioctl_assigned_device(struct kvm *kvm, unsigned ioctl,
>  			goto out_free_irq_routing;
>  		r = kvm_set_irq_routing(kvm, entries, routing.nr,
>  					routing.flags);
> -	out_free_irq_routing:
> +out_free_irq_routing:

This is a pointless change.

>  		vfree(entries);
>  		break;

You're wasting people's time here and we like newbies but it makes
everyone annoyed.

regards,
dan carpenter