From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH] virt: kvm: coding style cleanups
Date: Thu, 25 Nov 2010 07:00:32 +0300
Message-ID: <20101125040032.GR1522@bicker>
References: <1290644937.6078.9.camel@javier-laptop>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>,
	kvm@vger.kernel.org, kernel-janitors@vger.kernel.org
To: Javier Martinez Canillas <martinez.javier@gmail.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mail-wy0-f174.google.com ([74.125.82.174]:36838 "EHLO
	mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751567Ab0KYEAs (ORCPT <rfc822;kvm@vger.kernel.org>);
	Wed, 24 Nov 2010 23:00:48 -0500
Content-Disposition: inline
In-Reply-To: <1290644937.6078.9.camel@javier-laptop>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, Nov 25, 2010 at 01:28:57AM +0100, Javier Martinez Canillas wrote:
>  		adev->guest_msix_entries =
> -			kzalloc(sizeof(struct msix_entry) * entry_nr->entry_nr,
> +			kzalloc(sizeof(struct msix_entry) *entry_nr->entry_nr,

The original code was right and the new code is wrong.

>  				GFP_KERNEL);
>  		if (!adev->guest_msix_entries) {
>  			kfree(adev->host_msix_entries);
> @@ -750,7 +750,7 @@ long kvm_vm_ioctl_assigned_device(struct kvm *kvm, unsigned ioctl,
>  			goto out_free_irq_routing;
>  		r = kvm_set_irq_routing(kvm, entries, routing.nr,
>  					routing.flags);
> -	out_free_irq_routing:
> +out_free_irq_routing:

This is a pointless change.

>  		vfree(entries);
>  		break;

You're wasting people's time here and we like newbies but it makes
everyone annoyed.

regards,
dan carpenter