From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCHv6 00/16] boot order specification Date: Sun, 28 Nov 2010 09:54:04 +0200 Message-ID: <20101128075404.GF6897@redhat.com> References: <1290012243-6087-1-git-send-email-gleb@redhat.com> <20101123153141.GD25606@redhat.com> <4CEBE7F4.9080200@linux.vnet.ibm.com> <4CF1706A.3000507@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Anthony Liguori , qemu-devel@nongnu.org, kvm@vger.kernel.org, blauwirbel@gmail.com, armbru@redhat.com, alex.williamson@redhat.com, mst@redhat.com, kevin@koconnor.net, Anthony Liguori To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:59042 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751583Ab0K1Hy0 (ORCPT ); Sun, 28 Nov 2010 02:54:26 -0500 Content-Disposition: inline In-Reply-To: <4CF1706A.3000507@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Sat, Nov 27, 2010 at 10:56:10PM +0200, Avi Kivity wrote: > On 11/23/2010 06:12 PM, Anthony Liguori wrote: > >On 11/23/2010 09:31 AM, Gleb Natapov wrote: > >>Anthony, Blue > >> > >>No comments on this patch series for almost a week. Can it be applied? > > > >Does that mean everyone's happy or have folks not gotten around to > >review it? > > > >IOW, last call if you have objections :-) > > > > I haven't reviewed this - I trust the author and maintainers to get > it right. > > But I notice the there is no documentation - surely some is needed? > The patch creates Openfirmware device path from qdev hierarchy. Each element of a device path depends on type of a bus the device resides on. You can find various bus bindings here: http://playground.sun.com/1275/bindings/ and main spec is here http://forthworks.com/standards/of1275.pdf. Format in which list of device paths is passed to firmware is documented by comment (it is very simple). The only thing missing is command line option documentation. I will add it and resend if no more changes are needed for patch to be excepted. -- Gleb.