Re: [PATCH kvm-unit-tests 2/4] Introduce a C++ wrapper for the kvm APIs

Anthony Liguori
2010-11-24T16:58:06Z

On 11/24/2010 10:51 AM, Jes Sorensen wrote:
> On 11/24/10 17:47, Avi Kivity wrote:
>
>> On 11/24/2010 06:40 PM, Jes Sorensen wrote:
>>
>>> Well the problem here is that the i8042 is in the i440fx.c file, it
>>> shouldn't be there in the first place. The gluing together things in
>>> silicon is really just a way to shorten the wires and make it easier,
>>> they are still separate devices and as long as the i8042 requires ISA
>>> access, and to be treated like an ISA device, we should glue it onto the
>>> virtual ISA bus within QEMU.
>>>
>>> What you did above is making the exact same mistake as is done with the
>>> current i440fx.c code.
>>>
>> If a real life 440fx has an i8042, then an emulated 440fx should have an
>> emulated i8042. It's not complicated.
>>
> It's a question of how it is accessed, if it is treated like an ISA
> device by the silicon, we should treat it like an ISA device in QEMU,
> rather than pretend it is something that it isn't.
>

Does anyone have any evidence that the i8042 has anything to do with the
ISA bus at all other than the fact that people have some weird notion in
their head that if a pio/mmio operation isn't for a PCI device, it must
be ISA?

Regards,

Anthony Liguori