From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH 13/21] dma-helpers: replace bdrv_aio_writev() with bdrv_aio_writev_proxy(). Date: Sun, 28 Nov 2010 11:33:57 +0200 Message-ID: <20101128093357.GC3342@redhat.com> References: <1290665220-26478-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> <1290665220-26478-14-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org, avi@redhat.com, anthony@codemonkey.ws, aliguori@us.ibm.com, mtosatti@redhat.com, dlaor@redhat.com, ananth@in.ibm.com, psuriset@linux.vnet.ibm.com, vatsa@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com, ohmura.kei@lab.ntt.co.jp To: Yoshiaki Tamura Return-path: Received: from mx1.redhat.com ([209.132.183.28]:9709 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751922Ab0K1Jeo (ORCPT ); Sun, 28 Nov 2010 04:34:44 -0500 Content-Disposition: inline In-Reply-To: <1290665220-26478-14-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, Nov 25, 2010 at 03:06:52PM +0900, Yoshiaki Tamura wrote: > Replace bdrv_aio_writev() with bdrv_aio_writev_proxy() to let > event-tap capture events from dma-helpers. > > Signed-off-by: Yoshiaki Tamura Same comment as -net here: it's not clear when should a device use bdrv_aio_writev_proxy and when bdrv_aio_writev. If all devices should just use _proxy, let's just make bdrv_aio_writev DTRT instead. > --- > dma-helpers.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dma-helpers.c b/dma-helpers.c > index 712ed89..8ab2c26 100644 > --- a/dma-helpers.c > +++ b/dma-helpers.c > @@ -117,8 +117,8 @@ static void dma_bdrv_cb(void *opaque, int ret) > } > > if (dbs->is_write) { > - dbs->acb = bdrv_aio_writev(dbs->bs, dbs->sector_num, &dbs->iov, > - dbs->iov.size / 512, dma_bdrv_cb, dbs); > + dbs->acb = bdrv_aio_writev_proxy(dbs->bs, dbs->sector_num, &dbs->iov, > + dbs->iov.size / 512, dma_bdrv_cb, dbs); > } else { > dbs->acb = bdrv_aio_readv(dbs->bs, dbs->sector_num, &dbs->iov, > dbs->iov.size / 512, dma_bdrv_cb, dbs); > -- > 1.7.1.2 > > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html