From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Roedel, Joerg" Subject: Re: [PATCH 1/1] KVM: Pull extra page fault information into struct x86_exception Date: Mon, 29 Nov 2010 17:25:58 +0100 Message-ID: <20101129162558.GE2258@amd.com> References: <1291039950-8418-1-git-send-email-avi@redhat.com> <1291039950-8418-2-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: Marcelo Tosatti , "kvm@vger.kernel.org" , Gleb Natapov To: Avi Kivity Return-path: Received: from db3ehsobe003.messaging.microsoft.com ([213.199.154.141]:58274 "EHLO DB3EHSOBE003.bigfish.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752028Ab0K2Q0K (ORCPT ); Mon, 29 Nov 2010 11:26:10 -0500 Content-Disposition: inline In-Reply-To: <1291039950-8418-2-git-send-email-avi@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Nov 29, 2010 at 09:12:30AM -0500, Avi Kivity wrote: > Currently page fault cr2 and nesting infomation are carried outside > the fault data structure. Instead they are placed in the vcpu struct, > which results in confusion as global variables are manipulated instead > of passing parameters. > > Fix this issue by adding address and nested fields to struct x86_exception, > so this struct can carry all information associated with a fault. Tested with nnpt and found no regressions. > Signed-off-by: Avi Kivity Tested-by: Joerg Roedel -- AMD Operating System Research Center Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo, Andrew Bowd Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632