[PATCH 0/1] Clean up page fault injection

public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed

* [PATCH 0/1] Clean up page fault injection
@ 2010-11-29 14:12 Avi Kivity
  2010-11-29 14:12 ` [PATCH 1/1] KVM: Pull extra page fault information into struct x86_exception Avi Kivity
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Avi Kivity @ 2010-11-29 14:12 UTC (permalink / raw)
  To: Marcelo Tosatti, kvm, Joerg Roedel, Gleb Natapov

Currently fault injection is somewhat confused with important information
carried in the vcpu area where it has no place.  This patch cleans it up.

Gleb, Joerg, I'd appreciate review and testing of the apf and nnpt related
changes.

Goes on top of the previous 7-part emulator series.  Also available in
'emulator' branch of kvm.git.

Avi Kivity (1):
  KVM: Pull extra page fault information into struct x86_exception

 arch/x86/include/asm/kvm_emulate.h |    2 +
 arch/x86/include/asm/kvm_host.h    |   17 +++----------
 arch/x86/kvm/mmu.c                 |    5 ++-
 arch/x86/kvm/paging_tmpl.h         |    6 ++--
 arch/x86/kvm/svm.c                 |    7 +++--
 arch/x86/kvm/x86.c                 |   44 +++++++++++++++++++----------------
 6 files changed, 40 insertions(+), 41 deletions(-)


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/1] KVM: Pull extra page fault information into struct x86_exception
  2010-11-29 14:12 [PATCH 0/1] Clean up page fault injection Avi Kivity
@ 2010-11-29 14:12 ` Avi Kivity
  2010-11-29 16:25   ` Roedel, Joerg
  2010-11-30 11:20   ` Gleb Natapov
  2010-11-29 15:40 ` [PATCH 0/1] Clean up page fault injection Roedel, Joerg
  2010-12-02  2:07 ` Marcelo Tosatti
  2 siblings, 2 replies; 6+ messages in thread
From: Avi Kivity @ 2010-11-29 14:12 UTC (permalink / raw)
  To: Marcelo Tosatti, kvm, Joerg Roedel, Gleb Natapov

Currently page fault cr2 and nesting infomation are carried outside
the fault data structure.  Instead they are placed in the vcpu struct,
which results in confusion as global variables are manipulated instead
of passing parameters.

Fix this issue by adding address and nested fields to struct x86_exception,
so this struct can carry all information associated with a fault.

Signed-off-by: Avi Kivity <avi@redhat.com>
---
 arch/x86/include/asm/kvm_emulate.h |    2 +
 arch/x86/include/asm/kvm_host.h    |   17 +++----------
 arch/x86/kvm/mmu.c                 |    5 ++-
 arch/x86/kvm/paging_tmpl.h         |    6 ++--
 arch/x86/kvm/svm.c                 |    7 +++--
 arch/x86/kvm/x86.c                 |   44 +++++++++++++++++++----------------
 6 files changed, 40 insertions(+), 41 deletions(-)

diff --git a/arch/x86/include/asm/kvm_emulate.h b/arch/x86/include/asm/kvm_emulate.h
index 87d017e..bf70ece 100644
--- a/arch/x86/include/asm/kvm_emulate.h
+++ b/arch/x86/include/asm/kvm_emulate.h
@@ -19,6 +19,8 @@ struct x86_exception {
 	u8 vector;
 	bool error_code_valid;
 	u16 error_code;
+	bool nested_page_fault;
+	u64 address; /* cr2 or nested page fault gpa */
 };
 
 /*
diff --git a/arch/x86/include/asm/kvm_host.h b/arch/x86/include/asm/kvm_host.h
index 24bad0a..2621c4d 100644
--- a/arch/x86/include/asm/kvm_host.h
+++ b/arch/x86/include/asm/kvm_host.h
@@ -242,7 +242,8 @@ struct kvm_mmu {
 	void (*set_cr3)(struct kvm_vcpu *vcpu, unsigned long root);
 	unsigned long (*get_cr3)(struct kvm_vcpu *vcpu);
 	int (*page_fault)(struct kvm_vcpu *vcpu, gva_t gva, u32 err, bool no_apf);
-	void (*inject_page_fault)(struct kvm_vcpu *vcpu);
+	void (*inject_page_fault)(struct kvm_vcpu *vcpu,
+				  struct x86_exception *fault);
 	void (*free)(struct kvm_vcpu *vcpu);
 	gpa_t (*gva_to_gpa)(struct kvm_vcpu *vcpu, gva_t gva, u32 access,
 			    struct x86_exception *exception);
@@ -318,16 +319,6 @@ struct kvm_vcpu_arch {
 	 */
 	struct kvm_mmu *walk_mmu;
 
-	/*
-	 * This struct is filled with the necessary information to propagate a
-	 * page fault into the guest
-	 */
-	struct {
-		u64      address;
-		unsigned error_code;
-		bool     nested;
-	} fault;
-
 	/* only needed in kvm_pv_mmu_op() path, but it's hot so
 	 * put it here to avoid allocation */
 	struct kvm_pv_mmu_op_buffer mmu_op_buffer;
@@ -685,11 +676,11 @@ void kvm_queue_exception(struct kvm_vcpu *vcpu, unsigned nr);
 void kvm_queue_exception_e(struct kvm_vcpu *vcpu, unsigned nr, u32 error_code);
 void kvm_requeue_exception(struct kvm_vcpu *vcpu, unsigned nr);
 void kvm_requeue_exception_e(struct kvm_vcpu *vcpu, unsigned nr, u32 error_code);
-void kvm_inject_page_fault(struct kvm_vcpu *vcpu);
+void kvm_inject_page_fault(struct kvm_vcpu *vcpu, struct x86_exception *fault);
 int kvm_read_guest_page_mmu(struct kvm_vcpu *vcpu, struct kvm_mmu *mmu,
 			    gfn_t gfn, void *data, int offset, int len,
 			    u32 access);
-void kvm_propagate_fault(struct kvm_vcpu *vcpu);
+void kvm_propagate_fault(struct kvm_vcpu *vcpu, struct x86_exception *fault);
 bool kvm_require_cpl(struct kvm_vcpu *vcpu, int required_cpl);
 
 int kvm_pic_set_irq(void *opaque, int irq, int level);
diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c
index 28ddc13..e99afef 100644
--- a/arch/x86/kvm/mmu.c
+++ b/arch/x86/kvm/mmu.c
@@ -2737,9 +2737,10 @@ static unsigned long get_cr3(struct kvm_vcpu *vcpu)
 	return vcpu->arch.cr3;
 }
 
-static void inject_page_fault(struct kvm_vcpu *vcpu)
+static void inject_page_fault(struct kvm_vcpu *vcpu,
+			      struct x86_exception *fault)
 {
-	vcpu->arch.mmu.inject_page_fault(vcpu);
+	vcpu->arch.mmu.inject_page_fault(vcpu, fault);
 }
 
 static void paging_free(struct kvm_vcpu *vcpu)
diff --git a/arch/x86/kvm/paging_tmpl.h b/arch/x86/kvm/paging_tmpl.h
index aaed914..9a1990b 100644
--- a/arch/x86/kvm/paging_tmpl.h
+++ b/arch/x86/kvm/paging_tmpl.h
@@ -279,8 +279,8 @@ error:
 	if (rsvd_fault)
 		walker->fault.error_code |= PFERR_RSVD_MASK;
 
-	vcpu->arch.fault.address    = addr;
-	vcpu->arch.fault.error_code = walker->fault.error_code;
+	walker->fault.address = addr;
+	walker->fault.nested_page_fault = mmu != vcpu->arch.walk_mmu;
 
 	trace_kvm_mmu_walker_error(walker->fault.error_code);
 	return 0;
@@ -561,7 +561,7 @@ static int FNAME(page_fault)(struct kvm_vcpu *vcpu, gva_t addr, u32 error_code,
 	 */
 	if (!r) {
 		pgprintk("%s: guest page fault\n", __func__);
-		inject_page_fault(vcpu);
+		inject_page_fault(vcpu, &walker.fault);
 		vcpu->arch.last_pt_write_count = 0; /* reset fork detector */
 		return 0;
 	}
diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
index c6a7798..59669c2 100644
--- a/arch/x86/kvm/svm.c
+++ b/arch/x86/kvm/svm.c
@@ -1647,14 +1647,15 @@ static void nested_svm_set_tdp_cr3(struct kvm_vcpu *vcpu,
 	force_new_asid(vcpu);
 }
 
-static void nested_svm_inject_npf_exit(struct kvm_vcpu *vcpu)
+static void nested_svm_inject_npf_exit(struct kvm_vcpu *vcpu,
+				       struct x86_exception *fault)
 {
 	struct vcpu_svm *svm = to_svm(vcpu);
 
 	svm->vmcb->control.exit_code = SVM_EXIT_NPF;
 	svm->vmcb->control.exit_code_hi = 0;
-	svm->vmcb->control.exit_info_1 = vcpu->arch.fault.error_code;
-	svm->vmcb->control.exit_info_2 = vcpu->arch.fault.address;
+	svm->vmcb->control.exit_info_1 = fault->error_code;
+	svm->vmcb->control.exit_info_2 = fault->address;
 
 	nested_svm_vmexit(svm);
 }
diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
index bfd2878..495db8e 100644
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -339,23 +339,19 @@ void kvm_requeue_exception(struct kvm_vcpu *vcpu, unsigned nr)
 }
 EXPORT_SYMBOL_GPL(kvm_requeue_exception);
 
-void kvm_inject_page_fault(struct kvm_vcpu *vcpu)
+void kvm_inject_page_fault(struct kvm_vcpu *vcpu, struct x86_exception *fault)
 {
-	unsigned error_code = vcpu->arch.fault.error_code;
-
 	++vcpu->stat.pf_guest;
-	vcpu->arch.cr2 = vcpu->arch.fault.address;
-	kvm_queue_exception_e(vcpu, PF_VECTOR, error_code);
+	vcpu->arch.cr2 = fault->address;
+	kvm_queue_exception_e(vcpu, PF_VECTOR, fault->error_code);
 }
 
-void kvm_propagate_fault(struct kvm_vcpu *vcpu)
+void kvm_propagate_fault(struct kvm_vcpu *vcpu, struct x86_exception *fault)
 {
-	if (mmu_is_nested(vcpu) && !vcpu->arch.fault.nested)
-		vcpu->arch.nested_mmu.inject_page_fault(vcpu);
+	if (mmu_is_nested(vcpu) && !fault->nested_page_fault)
+		vcpu->arch.nested_mmu.inject_page_fault(vcpu, fault);
 	else
-		vcpu->arch.mmu.inject_page_fault(vcpu);
-
-	vcpu->arch.fault.nested = false;
+		vcpu->arch.mmu.inject_page_fault(vcpu, fault);
 }
 
 void kvm_inject_nmi(struct kvm_vcpu *vcpu)
@@ -3615,8 +3611,6 @@ static gpa_t translate_nested_gpa(struct kvm_vcpu *vcpu, gpa_t gpa, u32 access)
 	/* NPT walks are always user-walks */
 	access |= PFERR_USER_MASK;
 	t_gpa  = vcpu->arch.mmu.gva_to_gpa(vcpu, gpa, access, &exception);
-	if (t_gpa == UNMAPPED_GVA)
-		vcpu->arch.fault.nested = true;
 
 	return t_gpa;
 }
@@ -4264,7 +4258,7 @@ static void inject_emulated_exception(struct kvm_vcpu *vcpu)
 {
 	struct x86_emulate_ctxt *ctxt = &vcpu->arch.emulate_ctxt;
 	if (ctxt->exception.vector == PF_VECTOR)
-		kvm_propagate_fault(vcpu);
+		kvm_propagate_fault(vcpu, &ctxt->exception);
 	else if (ctxt->exception.error_code_valid)
 		kvm_queue_exception_e(vcpu, ctxt->exception.vector,
 				      ctxt->exception.error_code);
@@ -6265,6 +6259,8 @@ static int apf_put_user(struct kvm_vcpu *vcpu, u32 val)
 void kvm_arch_async_page_not_present(struct kvm_vcpu *vcpu,
 				     struct kvm_async_pf *work)
 {
+	struct x86_exception fault;
+
 	trace_kvm_async_pf_not_present(work->arch.token, work->gva);
 	kvm_add_async_pf_gfn(vcpu, work->arch.gfn);
 
@@ -6273,15 +6269,20 @@ void kvm_arch_async_page_not_present(struct kvm_vcpu *vcpu,
 	     kvm_x86_ops->get_cpl(vcpu) == 0))
 		kvm_make_request(KVM_REQ_APF_HALT, vcpu);
 	else if (!apf_put_user(vcpu, KVM_PV_REASON_PAGE_NOT_PRESENT)) {
-		vcpu->arch.fault.error_code = 0;
-		vcpu->arch.fault.address = work->arch.token;
-		kvm_inject_page_fault(vcpu);
+		fault.vector = PF_VECTOR;
+		fault.error_code_valid = true;
+		fault.error_code = 0;
+		fault.nested_page_fault = false;
+		fault.address = work->arch.token;
+		kvm_inject_page_fault(vcpu, &fault);
 	}
 }
 
 void kvm_arch_async_page_present(struct kvm_vcpu *vcpu,
 				 struct kvm_async_pf *work)
 {
+	struct x86_exception fault;
+
 	trace_kvm_async_pf_ready(work->arch.token, work->gva);
 	if (is_error_page(work->page))
 		work->arch.token = ~0; /* broadcast wakeup */
@@ -6290,9 +6291,12 @@ void kvm_arch_async_page_present(struct kvm_vcpu *vcpu,
 
 	if ((vcpu->arch.apf.msr_val & KVM_ASYNC_PF_ENABLED) &&
 	    !apf_put_user(vcpu, KVM_PV_REASON_PAGE_READY)) {
-		vcpu->arch.fault.error_code = 0;
-		vcpu->arch.fault.address = work->arch.token;
-		kvm_inject_page_fault(vcpu);
+		fault.vector = PF_VECTOR;
+		fault.error_code_valid = true;
+		fault.error_code = 0;
+		fault.nested_page_fault = false;
+		fault.address = work->arch.token;
+		kvm_inject_page_fault(vcpu, &fault);
 	}
 	vcpu->arch.apf.halted = false;
 }
-- 
1.7.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] KVM: Pull extra page fault information into struct x86_exception
  2010-11-29 14:12 ` [PATCH 1/1] KVM: Pull extra page fault information into struct x86_exception Avi Kivity
@ 2010-11-29 16:25   ` Roedel, Joerg
  2010-11-30 11:20   ` Gleb Natapov
  1 sibling, 0 replies; 6+ messages in thread
From: Roedel, Joerg @ 2010-11-29 16:25 UTC (permalink / raw)
  To: Avi Kivity; +Cc: Marcelo Tosatti, kvm@vger.kernel.org, Gleb Natapov

On Mon, Nov 29, 2010 at 09:12:30AM -0500, Avi Kivity wrote:
> Currently page fault cr2 and nesting infomation are carried outside
> the fault data structure.  Instead they are placed in the vcpu struct,
> which results in confusion as global variables are manipulated instead
> of passing parameters.
> 
> Fix this issue by adding address and nested fields to struct x86_exception,
> so this struct can carry all information associated with a fault.

Tested with nnpt and found no regressions.

> Signed-off-by: Avi Kivity <avi@redhat.com>

Tested-by: Joerg Roedel <joerg.roedel@amd.com>

-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/1] KVM: Pull extra page fault information into struct x86_exception
  2010-11-29 14:12 ` [PATCH 1/1] KVM: Pull extra page fault information into struct x86_exception Avi Kivity
  2010-11-29 16:25   ` Roedel, Joerg
@ 2010-11-30 11:20   ` Gleb Natapov
  1 sibling, 0 replies; 6+ messages in thread
From: Gleb Natapov @ 2010-11-30 11:20 UTC (permalink / raw)
  To: Avi Kivity; +Cc: Marcelo Tosatti, kvm, Joerg Roedel

On Mon, Nov 29, 2010 at 04:12:30PM +0200, Avi Kivity wrote:
> Currently page fault cr2 and nesting infomation are carried outside
> the fault data structure.  Instead they are placed in the vcpu struct,
> which results in confusion as global variables are manipulated instead
> of passing parameters.
> 
> Fix this issue by adding address and nested fields to struct x86_exception,
> so this struct can carry all information associated with a fault.
> 
> Signed-off-by: Avi Kivity <avi@redhat.com>
Tested-by: Gleb Natapov <gleb@redhat.com>

--
			Gleb.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/1] Clean up page fault injection
  2010-11-29 14:12 [PATCH 0/1] Clean up page fault injection Avi Kivity
  2010-11-29 14:12 ` [PATCH 1/1] KVM: Pull extra page fault information into struct x86_exception Avi Kivity
@ 2010-11-29 15:40 ` Roedel, Joerg
  2010-12-02  2:07 ` Marcelo Tosatti
  2 siblings, 0 replies; 6+ messages in thread
From: Roedel, Joerg @ 2010-11-29 15:40 UTC (permalink / raw)
  To: Avi Kivity; +Cc: Marcelo Tosatti, kvm@vger.kernel.org, Gleb Natapov

On Mon, Nov 29, 2010 at 09:12:29AM -0500, Avi Kivity wrote:
> Gleb, Joerg, I'd appreciate review and testing of the apf and nnpt related
> changes.

I'll give it a test as soon as possible.

	Joerg

-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/1] Clean up page fault injection
  2010-11-29 14:12 [PATCH 0/1] Clean up page fault injection Avi Kivity
  2010-11-29 14:12 ` [PATCH 1/1] KVM: Pull extra page fault information into struct x86_exception Avi Kivity
  2010-11-29 15:40 ` [PATCH 0/1] Clean up page fault injection Roedel, Joerg
@ 2010-12-02  2:07 ` Marcelo Tosatti
  2 siblings, 0 replies; 6+ messages in thread
From: Marcelo Tosatti @ 2010-12-02  2:07 UTC (permalink / raw)
  To: Avi Kivity; +Cc: kvm, Joerg Roedel, Gleb Natapov

On Mon, Nov 29, 2010 at 04:12:29PM +0200, Avi Kivity wrote:
> Currently fault injection is somewhat confused with important information
> carried in the vcpu area where it has no place.  This patch cleans it up.
> 
> Gleb, Joerg, I'd appreciate review and testing of the apf and nnpt related
> changes.
> 
> Goes on top of the previous 7-part emulator series.  Also available in
> 'emulator' branch of kvm.git.
> 
> Avi Kivity (1):
>   KVM: Pull extra page fault information into struct x86_exception
> 
>  arch/x86/include/asm/kvm_emulate.h |    2 +
>  arch/x86/include/asm/kvm_host.h    |   17 +++----------
>  arch/x86/kvm/mmu.c                 |    5 ++-
>  arch/x86/kvm/paging_tmpl.h         |    6 ++--
>  arch/x86/kvm/svm.c                 |    7 +++--
>  arch/x86/kvm/x86.c                 |   44 +++++++++++++++++++----------------
>  6 files changed, 40 insertions(+), 41 deletions(-)

Applied, thanks.


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2010-12-02  2:50 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-29 14:12 [PATCH 0/1] Clean up page fault injection Avi Kivity
2010-11-29 14:12 ` [PATCH 1/1] KVM: Pull extra page fault information into struct x86_exception Avi Kivity
2010-11-29 16:25   ` Roedel, Joerg
2010-11-30 11:20   ` Gleb Natapov
2010-11-29 15:40 ` [PATCH 0/1] Clean up page fault injection Roedel, Joerg
2010-12-02  2:07 ` Marcelo Tosatti

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox