From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH 0/7] Emulator exception improvements Date: Tue, 30 Nov 2010 12:47:45 -0200 Message-ID: <20101130144745.GA3825@amt.cnet> References: <1290441207-4250-1-git-send-email-avi@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:44377 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751984Ab0K3QXr (ORCPT ); Tue, 30 Nov 2010 11:23:47 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oAUGNl1Y032619 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 30 Nov 2010 11:23:47 -0500 Content-Disposition: inline In-Reply-To: <1290441207-4250-1-git-send-email-avi@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Nov 22, 2010 at 05:53:20PM +0200, Avi Kivity wrote: > This boring patchset introduces a struct x86_exception to represent an > exception, and uses it to communicate between the emulator and the rest > of kvm. The primary benefit is that we can now pass a #GP from kvm into > the emulator, not just #PFs. > > I'd like to also fold vcpu->arch.fault into struct x86_exception, but that's > more difficult, so deferred until later. > > Avi Kivity (7): > KVM: x86 emulator: introduce struct x86_exception to communicate > faults > KVM: x86 emulator: make emulator memory callbacks return full > exception > KVM: x86 emulator: drop dead pf injection in emulate_popf() > KVM: x86 emulator: tighen up ->read_std() and ->write_std() error > checks > KVM: x86 emulator: simplify exception generation > KVM: Push struct x86_exception info the various gva_to_gpa variants > KVM: Push struct x86_exception into walk_addr() > > arch/x86/include/asm/kvm_emulate.h | 26 +++-- > arch/x86/include/asm/kvm_host.h | 14 ++- > arch/x86/kvm/emulate.c | 243 ++++++++++++++---------------------- > arch/x86/kvm/mmu.c | 13 +- > arch/x86/kvm/paging_tmpl.h | 31 +++-- > arch/x86/kvm/x86.c | 97 ++++++++------- > 6 files changed, 195 insertions(+), 229 deletions(-) Applied, thanks.