From mboxrd@z Thu Jan  1 00:00:00 1970
From: Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
Subject: Re: [PATCH] qemu-kvm: response to SIGUSR1 to start/stop a VCPU (v2)
Date: Thu, 2 Dec 2010 18:43:12 +0530
Message-ID: <20101202131312.GC18445@linux.vnet.ibm.com>
References: <4CF6460C.5070604@redhat.com>
 <20101201161221.GA8073@linux.vnet.ibm.com>
 <1291220718.32004.1696.camel@laptop>
 <20101201172953.GF8073@linux.vnet.ibm.com>
 <1291225502.32004.1787.camel@laptop>
 <20101201180040.GH8073@linux.vnet.ibm.com>
 <1291230582.32004.1927.camel@laptop>
 <4CF76440.30500@redhat.com>
 <20101202114700.GA18445@linux.vnet.ibm.com>
 <4CF793FF.4010504@redhat.com>
Reply-To: vatsa@linux.vnet.ibm.com
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
	Anthony Liguori <aliguori@linux.vnet.ibm.com>,
	qemu-devel@nongnu.org, kvm@vger.kernel.org,
	Chris Wright <chrisw@sous-sol.org>,
	Ingo Molnar <mingo@elte.hu>, Mike Galbraith <efault@gmx.de>
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from e31.co.us.ibm.com ([32.97.110.149]:47938 "EHLO
	e31.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753358Ab0LBNNY (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 2 Dec 2010 08:13:24 -0500
Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227])
	by e31.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id oB2Cxoha031793
	for <kvm@vger.kernel.org>; Thu, 2 Dec 2010 05:59:50 -0700
Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168])
	by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id oB2DDHf3208286
	for <kvm@vger.kernel.org>; Thu, 2 Dec 2010 06:13:17 -0700
Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1])
	by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id oB2DDGme026362
	for <kvm@vger.kernel.org>; Thu, 2 Dec 2010 06:13:17 -0700
Content-Disposition: inline
In-Reply-To: <4CF793FF.4010504@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, Dec 02, 2010 at 02:41:35PM +0200, Avi Kivity wrote:
> >>  What I'd like to see in directed yield is donating exactly the
> >>  amount of vruntime that's needed to make the target thread run.
> >
> >I presume this requires the target vcpu to move left in rb-tree to run
> >earlier than scheduled currently and that it doesn't involve any
> >change to the sched_period() of target vcpu?
> >
> >Just was wondering how this would work in case of buggy guests. Lets say that a
> >guest ran into a AB<->BA deadlock. VCPU0 spins on lock B (held by VCPU1
> >currently), while VCPU spins on lock A (held by VCPU0 currently). Both keep
> >boosting each other's vruntime, potentially affecting fairtime for other guests
> >(to the point of starving them perhaps)?
> 
> We preserve vruntime overall.  If you give vruntime to someone, it
> comes at your own expense.  Overall vruntime is preserved.

Hmm ..so I presume that this means we don't affect target thread's position in
rb-tree upon donation, rather we influence its sched_period() to include 
donated time? IOW donation has no effect on causing the target thread to run
"immediately", rather it will have the effect of causing it run "longer"
whenever it runs next?

Even that would require some precaution in directed yield to ensure that it
doesn't unduly inflate vruntime of target, hurting fairness for other guests on
same cpu as target (example guest code that can lead to this situation 
below):

vcpu0:				vcpu1:

				spinlock(A);

spinlock(A);            

                        	while(1)
				;
 
			 	spin_unlock(A);

- vatsa