From: Chris Wright <chrisw@sous-sol.org>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Chris Wright <chrisw@sous-sol.org>,
Marcelo Tosatti <mtosatti@redhat.com>,
kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>,
Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
Subject: Re: [PATCH] kvm-vmx: add module parameter to avoid trapping HLT instructions (v2)
Date: Thu, 2 Dec 2010 18:42:21 -0800 [thread overview]
Message-ID: <20101203024221.GX10050@sequoia.sous-sol.org> (raw)
In-Reply-To: <4CF81FC6.7090503@codemonkey.ws>
* Anthony Liguori (anthony@codemonkey.ws) wrote:
> On 12/02/2010 03:07 PM, Chris Wright wrote:
> >Like non-trapping hlt, that too will guarantee that the guest is preempted
> >by timeslice exhaustion (and is simpler than non-trapping hlt). So it
> >may well be the simplest for the case where we are perfectly committed
> >(i.e. the vcpu fractional core count totals the pcpu count). But once
> >we are undercommitted we still need some extra logic to handle the hard
> >cap and something to kick the running guest off the cpu and suck up the
> >extra cycles in a power conserving way.
>
> I'm not entirely sure TBH.
>
> If you think of a cloud's per-VCPU capacity in terms of Compute
> Units, having a model where a VCPU maps to 1-3 units depending on
> total load is potentially interesting particularly if the VCPU's
> capacity only changes in discrete amounts, that the expected
> capacity is communicated to the guest, and that the capacity only
> changes periodically.
OK, let's say a single PCPU == 12 Compute Units.
If the guest is the first to migrate to a newly added unused host, and
we are using either non-trapping hlt or Marcelo's non-yielding trapping
hlt, then that guest is going to get more CPU than it expected unless
there is some throttling mechanism. Specifically, it will get 12CU
instead of 1-3CU.
Do you agree with that?
thanks,
-chris
next prev parent reply other threads:[~2010-12-03 2:42 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-02 13:59 [PATCH] kvm-vmx: add module parameter to avoid trapping HLT instructions (v2) Anthony Liguori
2010-12-02 14:39 ` lidong chen
2010-12-02 15:23 ` Anthony Liguori
2010-12-02 15:23 ` Anthony Liguori
2010-12-03 9:38 ` Avi Kivity
2010-12-03 11:12 ` Srivatsa Vaddagiri
2010-12-03 23:28 ` Anthony Liguori
2010-12-02 17:37 ` Marcelo Tosatti
2010-12-02 19:07 ` Anthony Liguori
2010-12-02 20:12 ` Marcelo Tosatti
2010-12-02 20:51 ` Anthony Liguori
2010-12-03 9:36 ` Avi Kivity
2010-12-03 22:45 ` Anthony Liguori
2010-12-04 8:13 ` Avi Kivity
2010-12-04 13:30 ` Anthony Liguori
2010-12-06 8:28 ` Avi Kivity
2010-12-06 8:35 ` Avi Kivity
2010-12-06 13:58 ` Anthony Liguori
2010-12-06 14:01 ` Avi Kivity
2010-12-06 14:02 ` Avi Kivity
2010-12-06 14:08 ` Anthony Liguori
2010-12-06 14:14 ` Gleb Natapov
2010-12-06 14:03 ` Anthony Liguori
2010-12-06 14:33 ` Avi Kivity
2010-12-06 15:07 ` Anthony Liguori
2010-12-06 15:16 ` Avi Kivity
2010-12-06 16:21 ` Anthony Liguori
2010-12-06 16:30 ` Avi Kivity
2010-12-06 16:33 ` Anthony Liguori
2010-12-03 12:40 ` Gleb Natapov
2010-12-03 23:31 ` Anthony Liguori
2010-12-03 22:42 ` Anthony Liguori
2010-12-04 8:16 ` Avi Kivity
2010-12-04 13:48 ` Anthony Liguori
2010-12-06 8:32 ` Avi Kivity
2010-12-02 19:14 ` Chris Wright
2010-12-02 20:25 ` Anthony Liguori
2010-12-02 20:40 ` Chris Wright
2010-12-02 20:40 ` Marcelo Tosatti
2010-12-02 21:07 ` Chris Wright
2010-12-02 22:37 ` Anthony Liguori
2010-12-03 2:42 ` Chris Wright [this message]
2010-12-03 3:21 ` Anthony Liguori
2010-12-03 3:44 ` Chris Wright
2010-12-03 14:25 ` Anthony Liguori
2010-12-02 22:27 ` Anthony Liguori
2010-12-03 22:49 ` Anthony Liguori
2010-12-04 5:43 ` Srivatsa Vaddagiri
2010-12-03 9:40 ` Avi Kivity
2010-12-03 11:21 ` Srivatsa Vaddagiri
2010-12-03 11:57 ` Srivatsa Vaddagiri
2010-12-03 16:27 ` Srivatsa Vaddagiri
2010-12-03 17:29 ` Chris Wright
2010-12-03 17:33 ` Srivatsa Vaddagiri
2010-12-04 8:18 ` Avi Kivity
2010-12-03 17:57 ` Srivatsa Vaddagiri
2010-12-03 17:58 ` Chris Wright
2010-12-03 18:07 ` Anthony Liguori
2010-12-03 18:12 ` Srivatsa Vaddagiri
2010-12-04 8:19 ` Avi Kivity
2010-12-03 18:20 ` Chris Wright
2010-12-03 18:55 ` Anthony Liguori
2010-12-03 18:10 ` Marcelo Tosatti
2010-12-03 18:24 ` Marcelo Tosatti
2010-12-03 17:28 ` Chris Wright
2010-12-03 17:36 ` Srivatsa Vaddagiri
2010-12-03 17:38 ` Chris Wright
2010-12-03 17:43 ` Srivatsa Vaddagiri
2010-12-03 17:47 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101203024221.GX10050@sequoia.sous-sol.org \
--to=chrisw@sous-sol.org \
--cc=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=vatsa@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox