Re: [RFC PATCH 0/3] directed yield for Pause Loop Exiting

Rik van Riel
2010-12-10T14:54:56Z

On 12/10/2010 12:03 AM, Balbir Singh wrote:

> This is a good problem statement, there are other things to consider
> as well
>
> 1. If a hard limit feature is enabled underneath, donating the
> timeslice would probably not make too much sense in that case

The idea is to get the VCPU that is holding the lock to run
ASAP, so it can release the lock.

> 2. The implict assumption is that spinning is bad, but for locks
> held for short durations, the assumption is not true. I presume
> by the problem statement above, the h/w does the detection of
> when to pause, but that is not always correct as you suggest above.

The hardware waits a certain number of spins before it traps
to the virt host. Short-held locks, held by a virtual CPU
that is running, will not trigger the exception.

> 3. With respect to donating timeslices, don't scheduler cgroups
> and job isolation address that problem today?

No.

--
All rights reversed