From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marcelo Tosatti Subject: Re: [PATCH] kvm-vmx: add module parameter to avoid trapping HLT instructions (v2) Date: Fri, 3 Dec 2010 16:10:43 -0200 Message-ID: <20101203181043.GA22929@amt.cnet> References: <1291298357-5695-1-git-send-email-aliguori@us.ibm.com> <20101202191416.GQ10050@sequoia.sous-sol.org> <20101203115752.GD27994@linux.vnet.ibm.com> <20101203162731.GA11725@linux.vnet.ibm.com> <20101203172906.GD10050@sequoia.sous-sol.org> <20101203175744.GE13515@linux.vnet.ibm.com> <20101203175854.GF10050@sequoia.sous-sol.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Srivatsa Vaddagiri , Anthony Liguori , kvm@vger.kernel.org, Avi Kivity To: Chris Wright Return-path: Received: from mx1.redhat.com ([209.132.183.28]:8734 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751550Ab0LCSOJ (ORCPT ); Fri, 3 Dec 2010 13:14:09 -0500 Content-Disposition: inline In-Reply-To: <20101203175854.GF10050@sequoia.sous-sol.org> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Dec 03, 2010 at 09:58:54AM -0800, Chris Wright wrote: > * Srivatsa Vaddagiri (vatsa@linux.vnet.ibm.com) wrote: > > On Fri, Dec 03, 2010 at 09:29:06AM -0800, Chris Wright wrote: > > > That's what Marcelo's suggestion does w/out a fill thread. > > > > There's one complication though even with that. How do we compute the > > real utilization of VM (given that it will appear to be burning 100% cycles)? > > We need to have scheduler discount the cycles burnt post halt-exit, so more > > stuff is needed than those simple 3-4 lines! > > Heh, was just about to say the same thing ;) Probably yes. The point is, you get the same effect as with the non-trapping hlt but without the complications on low-level VMX/SVM code. Even better if you can do it with fill thread idea.