From: Joerg Roedel <joro@8bytes.org>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Chris Wright <chrisw@sous-sol.org>,
Srivatsa Vaddagiri <vatsa@linux.vnet.ibm.com>
Subject: Re: [PATCH] kvm-vmx: add module parameter to avoid trapping HLT instructions (v3)
Date: Sat, 4 Dec 2010 00:32:31 +0100 [thread overview]
Message-ID: <20101203233231.GA29502@8bytes.org> (raw)
In-Reply-To: <1291415962-13762-1-git-send-email-aliguori@us.ibm.com>
On Fri, Dec 03, 2010 at 04:39:22PM -0600, Anthony Liguori wrote:
> + if (yield_on_hlt)
> + min |= CPU_BASED_HLT_EXITING;
This approach won't work out on AMD because in HLT the CPU may enter
C1e. In C1e the local apic timer interupt is not delivered anymore and
when this is the current timer in use the cpu may miss timer ticks or
never comes out of HLT again. The guest has no chance to work around
this as the Linux idle routine does.
If you really wan't active idling of a guest, it should idle in the
hypervisor where it can work around such problems.
Joerg
next prev parent reply other threads:[~2010-12-03 23:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-03 22:39 [PATCH] kvm-vmx: add module parameter to avoid trapping HLT instructions (v3) Anthony Liguori
2010-12-03 23:32 ` Joerg Roedel [this message]
2010-12-03 23:38 ` Anthony Liguori
2010-12-04 8:53 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101203233231.GA29502@8bytes.org \
--to=joro@8bytes.org \
--cc=aliguori@us.ibm.com \
--cc=avi@redhat.com \
--cc=chrisw@sous-sol.org \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=vatsa@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox