public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: "Roedel, Joerg" <Joerg.Roedel@amd.com>
To: Avi Kivity <avi@redhat.com>
Cc: "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH 0/2] Emulator intercept frameworks
Date: Mon, 6 Dec 2010 11:53:19 +0100	[thread overview]
Message-ID: <20101206105318.GE4936@amd.com> (raw)
In-Reply-To: <1291544305-19739-1-git-send-email-avi@redhat.com>

Hi Avi,

On Sun, Dec 05, 2010 at 05:18:23AM -0500, Avi Kivity wrote:
> This patchset defines a framework for intercepting emulated instructions.  It
> takes a middle ground to the two previous proposals: putting everything in
> an arch callback, or putting everything in the emulator.  Instead, it marks
> each interceptable instruction with an intercept code that it passes to an
> arch callback.  The intercept code can then be used to index a table that
> looks up the correct VMCB bit and exit reason (for the case of SVM).

Thanks for that infrastructure work. This interface looks indeed better
than my original one. Most of the instruction decoding stuff (which was
the code duplication between the x86_emulate_insn function) can be
removed now.
 
> Joerg, if this looks right to you, please integrate it into your emulator
> intercept patchset.

Will do. It will probably take until January before I am done with this.
There is some other stuff to do first.

	Joerg

-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632


  parent reply	other threads:[~2010-12-06 10:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-05 10:18 [PATCH 0/2] Emulator intercept frameworks Avi Kivity
2010-12-05 10:18 ` [PATCH 1/2] KVM: x86 emulator: add framework for instruction intercepts Avi Kivity
2010-12-05 10:18 ` [PATCH 2/2] KVM: x86 emulator: add SVM intercepts Avi Kivity
2010-12-05 11:56   ` Avi Kivity
2010-12-06 10:53 ` Roedel, Joerg [this message]
2011-02-03 16:07   ` [PATCH 0/2] Emulator intercept frameworks Avi Kivity
2011-02-03 16:18     ` Roedel, Joerg
2011-02-03 16:30       ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101206105318.GE4936@amd.com \
    --to=joerg.roedel@amd.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox