From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luiz Capitulino Subject: Re: [PATCH v2 2/2] qemu,qmp: convert do_inject_nmi() to QObject, QError Date: Fri, 10 Dec 2010 09:20:26 -0200 Message-ID: <20101210092026.2a1d037d@doriath> References: <4D01CA58.3010306@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org, avi@redhat.com, aliguori@us.ibm.com To: Lai Jiangshan Return-path: Received: from mx1.redhat.com ([209.132.183.28]:15976 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754517Ab0LJLUp (ORCPT ); Fri, 10 Dec 2010 06:20:45 -0500 In-Reply-To: <4D01CA58.3010306@cn.fujitsu.com> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, 10 Dec 2010 14:36:08 +0800 Lai Jiangshan wrote: > +SQMP > +inject_nmi > +---------- > + > +Inject an NMI on the given CPU (x86 only). > + > +Arguments: > + > +- "cpu_index": the index of the CPU to be injected NMI (json-int) > + > +Example: > + > +-> { "execute": "inject_nmi", "arguments": { "cpu_index": 0 } } > +<- { "return": {} } > + > +EQMP > + Avi, Anthony, can you please review this? Do we expect some kind of ack from the guest? Do we expect it respond in some way? Also note that the current series defines only one error condition: invalid cpu index. Can this fail in other ways?