From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luiz Capitulino Subject: Re: [PATCH v3] qemu,qmp: convert do_inject_nmi() to QObject, QError Date: Thu, 16 Dec 2010 08:48:15 -0200 Message-ID: <20101216084815.3ca77188@doriath> References: <4D088F27.8000909@cn.fujitsu.com> <20101215150911.14e1693f@doriath> <4D08F868.5090100@redhat.com> <20101215152606.078147ad@doriath> <20101215160000.16f85795@doriath> <4D09D5EA.7070000@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Markus Armbruster , Lai Jiangshan , qemu-devel@nongnu.org, kvm@vger.kernel.org, aliguori@us.ibm.com To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:19457 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753852Ab0LPKsf (ORCPT ); Thu, 16 Dec 2010 05:48:35 -0500 In-Reply-To: <4D09D5EA.7070000@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, 16 Dec 2010 11:03:38 +0200 Avi Kivity wrote: > On 12/15/2010 08:00 PM, Luiz Capitulino wrote: > > > > > > > > Looks like a GUI feature to me, > > > > > > Really? Can't see how you can build "NMI to all CPUs" from "NMI this > > > CPU". Or am I misunderstanding you? > > > > I guess so. Avi referred to 'nmi button on many machines', I assumed he > > meant a virtual machine GUI, am I wrong? > > I meant a real machine's GUI (it's a physical button you can press with > your finger, if you have thin fingers). Ok, I didn't know that, but I had another idea: the command could accept either a single cpu index or a list: { "execute": "inject-nmi", "arguments": { "cpus": 2 } } { "execute": "inject-nmi", "arguments": { "cpus": [1, 2, 3, 4] } } This has the feature of injecting the nmi in just some cpus, although I'm not sure this is going to be desired/useful. If we agree on this we'll have to wait because the monitor doesn't currently support "hybrid" arguments.