Re: [Qemu-devel] [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

Markus Armbruster
2010-12-15T10:49:41Z

Lai Jiangshan <laijs@cn.fujitsu.com> writes:

> Convert do_inject_nmi() to QObject, QError, we need to use it(via libvirt).
>
> changed from v1
> Add document.
> Add error handling when the cpu index is invalid.
>
> changed from v2
> use QERR_INVALID_PARAMETER_VALUE as Markus suggest.
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>

A note on commit messages:

The commit message should describe the current version of the patch.
Don't repeat the subject line in the body.

Patch history is very useful for review, but usually uninteresting once
the patch is committed. Thus, it's best to put it after the "---"
separator.

Subsystem tags in the subject line are helpful. But "qemu" doesn't
provide any information there :)

Regarding the patch:

The conversion looks good.

The new QMP command is called "inject_nmi", while the existing human
monitor command is called "nmi". Luiz asked for this name change. I
don't mind. But should we rename the human monitor command for
consistency?

Regardless, the differing command name is worth mentioning in the commit
message.