From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [PATCH v3] qemu,qmp: convert do_inject_nmi() to QObject, QError
Date: Thu, 16 Dec 2010 09:12:13 -0200
Message-ID: <20101216091213.214de980@doriath>
References: <4D088F27.8000909@cn.fujitsu.com>
	<20101215150911.14e1693f@doriath>
	<4D08F868.5090100@redhat.com>
	<20101215152606.078147ad@doriath>
	<m3aak7ylp6.fsf@blackfin.pond.sub.org>
	<20101215160000.16f85795@doriath>
	<4D09D5EA.7070000@redhat.com>
	<20101216084815.3ca77188@doriath>
	<4D09EF22.4030706@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Markus Armbruster <armbru@redhat.com>,
	Lai Jiangshan <laijs@cn.fujitsu.com>, qemu-devel@nongnu.org,
	kvm@vger.kernel.org, aliguori@us.ibm.com
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:35310 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753852Ab0LPLMd (ORCPT <rfc822;kvm@vger.kernel.org>);
	Thu, 16 Dec 2010 06:12:33 -0500
In-Reply-To: <4D09EF22.4030706@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Thu, 16 Dec 2010 12:51:14 +0200
Avi Kivity <avi@redhat.com> wrote:

> On 12/16/2010 12:48 PM, Luiz Capitulino wrote:
> > Ok, I didn't know that, but I had another idea: the command could accept
> > either a single cpu index or a list:
> >
> >
> >    { "execute": "inject-nmi", "arguments": { "cpus": 2 } }
> >
> >    { "execute": "inject-nmi", "arguments": { "cpus": [1, 2, 3, 4] } }
> >
> > This has the feature of injecting the nmi in just some cpus, although I'm
> > not sure this is going to be desired/useful.
> >
> > If we agree on this we'll have to wait because the monitor doesn't currently
> > support "hybrid" arguments.
> 
> I hope it never does.  They're hard to support in old-school statically 
> typed languages.

We could accept only a list then.