Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

Lai Jiangshan
2010-12-17T06:19:11Z

On 12/16/2010 09:17 PM, Luiz Capitulino wrote:
> On Thu, 16 Dec 2010 15:11:50 +0200
> Avi Kivity <avi@redhat.com> wrote:
>>
>> Why have an argument at all? Always nmi to all cpus.
>

I think Avi's suggest is better, and I will use
"inject-nmi" (without cpu-index argument) to send NMI to all cpus,
like physical GUI. If some one want to send NMI to a set of cpus,
he can use "inject-nmi" multiple times.

I also like "cpu-index", so I have to add another patch for
coverting current "cpu_index" to "cpu-index".

Thanks,
Lai