Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError

Markus Armbruster
2010-12-16T11:48:05Z

Luiz Capitulino <lcapitulino@redhat.com> writes:

> On Thu, 16 Dec 2010 11:03:38 +0200
> Avi Kivity <avi@redhat.com> wrote:
>
>> On 12/15/2010 08:00 PM, Luiz Capitulino wrote:
>> > > >
>> > > > Looks like a GUI feature to me,
>> > >
>> > > Really? Can't see how you can build "NMI to all CPUs" from "NMI this
>> > > CPU". Or am I misunderstanding you?
>> >
>> > I guess so. Avi referred to 'nmi button on many machines', I assumed he
>> > meant a virtual machine GUI, am I wrong?
>>
>> I meant a real machine's GUI (it's a physical button you can press with
>> your finger, if you have thin fingers).
>
> Ok, I didn't know that, but I had another idea: the command could accept
> either a single cpu index or a list:
>
>
> { "execute": "inject-nmi", "arguments": { "cpus": 2 } }
>
> { "execute": "inject-nmi", "arguments": { "cpus": [1, 2, 3, 4] } }
>
> This has the feature of injecting the nmi in just some cpus, although I'm
> not sure this is going to be desired/useful.

Use case for NMI-ing a subset of the CPUs?

Heck, use case for anything else but "NMI all"?

> If we agree on this we'll have to wait because the monitor doesn't currently
> support "hybrid" arguments.

Let's keep the schema simple.