Re: [Qemu-devel] [PATCH 06/21] vl: add a tmp pointer so that a handler can delete the entry to which it belongs.

Isaku Yamahata
2010-12-08T07:03:59Z

QLIST_FOREACH_SAFE?

On Thu, Nov 25, 2010 at 03:06:45PM +0900, Yoshiaki Tamura wrote:
> By copying the next entry to a tmp pointer,
> qemu_del_vm_change_state_handler() can be called in the handler.
>
> Signed-off-by: Yoshiaki Tamura <tamura.yoshiaki@lab.ntt.co.jp>
> ---
> vl.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 805e11f..6b6aec0 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -1073,11 +1073,12 @@ void qemu_del_vm_change_state_handler(VMChangeStateEntry *e)
>
> void vm_state_notify(int running, int reason)
> {
> - VMChangeStateEntry *e;
> + VMChangeStateEntry *e, *ne;
>
> trace_vm_state_notify(running, reason);
>
> - for (e = vm_change_state_head.lh_first; e; e = e->entries.le_next) {
> + for (e = vm_change_state_head.lh_first; e; e = ne) {
> + ne = e->entries.le_next;
> e->cb(e->opaque, running, reason);
> }
> }
> --
> 1.7.1.2
>
>

--
yamahata