From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luiz Capitulino Subject: Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi() to QObject, QError Date: Thu, 16 Dec 2010 11:17:52 -0200 Message-ID: <20101216111752.77757c00@doriath> References: <4D088F27.8000909@cn.fujitsu.com> <20101215150911.14e1693f@doriath> <4D08F868.5090100@redhat.com> <20101215152606.078147ad@doriath> <20101215160000.16f85795@doriath> <4D09D5EA.7070000@redhat.com> <20101216084815.3ca77188@doriath> <4D0A0B00.3070108@redhat.com> <20101216110917.646779b7@doriath> <4D0A1016.7060408@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Markus Armbruster , qemu-devel@nongnu.org, aliguori@us.ibm.com, kvm@vger.kernel.org, Lai Jiangshan To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:58814 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755532Ab0LPNSL (ORCPT ); Thu, 16 Dec 2010 08:18:11 -0500 In-Reply-To: <4D0A1016.7060408@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Thu, 16 Dec 2010 15:11:50 +0200 Avi Kivity wrote: > On 12/16/2010 03:09 PM, Luiz Capitulino wrote: > > On Thu, 16 Dec 2010 14:50:08 +0200 > > Avi Kivity wrote: > > > > > On 12/16/2010 01:47 PM, Markus Armbruster wrote: > > > > > > > > > > This has the feature of injecting the nmi in just some cpus, although I'm > > > > > not sure this is going to be desired/useful. > > > > > > > > Use case for NMI-ing a subset of the CPUs? > > > > > > > > Heck, use case for anything else but "NMI all"? > > > > > > Exactly. > > > > Then I think the to-all-cpus argument is better. > > Why have an argument at all? Always nmi to all cpus. That's possible too.