From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: [PATCH v2 2/2] qemu,qmp: convert do_inject_nmi() to QObject,
 QError
Date: Mon, 20 Dec 2010 08:47:46 -0200
Message-ID: <20101220104746.GC16707@amt.cnet>
References: <4D01CA58.3010306@cn.fujitsu.com>
 <20101210092026.2a1d037d@doriath>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>, qemu-devel@nongnu.org,
	kvm@vger.kernel.org, avi@redhat.com, aliguori@us.ibm.com
To: Luiz Capitulino <lcapitulino@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:53515 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755645Ab0LTLeN (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 20 Dec 2010 06:34:13 -0500
Content-Disposition: inline
In-Reply-To: <20101210092026.2a1d037d@doriath>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Fri, Dec 10, 2010 at 09:20:26AM -0200, Luiz Capitulino wrote:
> On Fri, 10 Dec 2010 14:36:08 +0800
> Lai Jiangshan <laijs@cn.fujitsu.com> wrote:
> 
> > +SQMP
> > +inject_nmi
> > +----------
> > +
> > +Inject an NMI on the given CPU (x86 only).
> > +
> > +Arguments:
> > +
> > +- "cpu_index": the index of the CPU to be injected NMI (json-int)
> > +
> > +Example:
> > +
> > +-> { "execute": "inject_nmi", "arguments": { "cpu_index": 0 } }
> > +<- { "return": {} }
> > +
> > +EQMP
> > +
> 
> Avi, Anthony, can you please review this? Do we expect some kind of ack from
> the guest? Do we expect it respond in some way?

Looks good to me. Don't except any response from the guest.

> Also note that the current series defines only one error condition: invalid
> cpu index. Can this fail in other ways?
> --

Not really. An NMI can be pending already (which means the current
command has no effect), but i don't see the need to report that.