public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Jin Dongming <jin.dongming@np.css.fujitsu.com>
Cc: Avi Kivity <avi@redhat.com>, Andi Kleen <andi@firstfloor.org>,
	Huang Ying <ying.huang@intel.com>,
	Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
	Dean Nelson <dnelson@redhat.com>, KVM list <kvm@vger.kernel.org>
Subject: Re: [PATCH 3/3] kvm, x86: introduce kvm_inject_x86_mce_on
Date: Mon, 20 Dec 2010 09:29:53 -0200	[thread overview]
Message-ID: <20101220112953.GB21124@amt.cnet> (raw)
In-Reply-To: <4D01E3F0.7080305@np.css.fujitsu.com>

On Fri, Dec 10, 2010 at 05:25:20PM +0900, Jin Dongming wrote:
> Pass a table instead of multiple args.
> 
> Note:
> 
>     kvm_inject_x86_mce(env, bank, status, mcg_status, addr, misc,
>                        abort_on_error);
> 
> is equal to:
> 
>     struct kvm_x86_mce mce = {
>         .bank = bank,
>         .status = status,
>         .mcg_status = mcg_status,
>         .addr = addr,
>         .misc = misc,
>     };
>     kvm_inject_x86_mce_on(env, &mce, abort_on_error);
> 
> Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
> Signed-off-by: Jin Dongming <jin.dongming@np.css.fujitsu.com>

Looks good, can you please regenerate against qemu-kvm.git's uq/master
branch?

  reply	other threads:[~2010-12-20 11:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-10  8:25 [PATCH 3/3] kvm, x86: introduce kvm_inject_x86_mce_on Jin Dongming
2010-12-20 11:29 ` Marcelo Tosatti [this message]
2010-12-20 23:57   ` Jin Dongming
  -- strict thread matches above, loose matches on Subject: below --
2010-12-22  3:24 Jin Dongming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101220112953.GB21124@amt.cnet \
    --to=mtosatti@redhat.com \
    --cc=andi@firstfloor.org \
    --cc=avi@redhat.com \
    --cc=dnelson@redhat.com \
    --cc=jin.dongming@np.css.fujitsu.com \
    --cc=kvm@vger.kernel.org \
    --cc=seto.hidetoshi@jp.fujitsu.com \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox