Re: [PATCH] pci-stub: ignore zero-length id parameters

[Jesse Barnes <jbarnes@virtuousgeek.org>]

On Wed, 22 Dec 2010 10:06:36 +0100
Tejun Heo <tj@kernel.org> wrote:

> pci-stub uses strsep() to separate list of ids and generates a warning
> message when it fails to parse an id.  However, not specifying the
> parameter results in ids set to an empty string.  strsep() happily
> returns the empty string as the first token and thus triggers the
> warning message spuriously.
> 
> Make the tokner ignore zero length ids.
> 
> Reported-by: Chris Wright <chrisw@sous-sol.org>
> Reported-by: Prasad Joshi <P.G.Joshi@student.reading.ac.uk>
> Cc: stable@kernel.org
> ---
>  drivers/pci/pci-stub.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/pci/pci-stub.c b/drivers/pci/pci-stub.c
> index f7b68ca..4ae494b 100644
> --- a/drivers/pci/pci-stub.c
> +++ b/drivers/pci/pci-stub.c
> @@ -54,6 +54,9 @@ static int __init pci_stub_init(void)
>  			subdevice = PCI_ANY_ID, class=0, class_mask=0;
>  		int fields;
>  
> +		if (!strlen(id))
> +			continue;
> +
>  		fields = sscanf(id, "%x:%x:%x:%x:%x:%x",
>  				&vendor, &device, &subvendor, &subdevice,
>  				&class, &class_mask);
> 

Applied to my linux-next branch, thanks.

-- 
Jesse Barnes, Intel Open Source Technology Center