From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH 18/19] Introduce -k option to enable FT migration mode (Kemari). Date: Mon, 27 Dec 2010 10:56:17 +0200 Message-ID: <20101227085617.GA22317@redhat.com> References: <1293438337-21377-1-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> <1293438337-21377-19-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org, avi@redhat.com, anthony@codemonkey.ws, aliguori@us.ibm.com, mtosatti@redhat.com, dlaor@redhat.com, kwolf@redhat.com, ananth@in.ibm.com, psuriset@linux.vnet.ibm.com, vatsa@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com, ohmura.kei@lab.ntt.co.jp To: Yoshiaki Tamura Return-path: Received: from mx1.redhat.com ([209.132.183.28]:58999 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752523Ab0L0I4t (ORCPT ); Mon, 27 Dec 2010 03:56:49 -0500 Content-Disposition: inline In-Reply-To: <1293438337-21377-19-git-send-email-tamura.yoshiaki@lab.ntt.co.jp> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Dec 27, 2010 at 05:25:36PM +0900, Yoshiaki Tamura wrote: > When -k option is set to migrate command, it will turn on ft_mode to > start FT migration mode (Kemari). > > Signed-off-by: Yoshiaki Tamura > --- > hmp-commands.hx | 7 ++++--- > migration.c | 3 +++ > qmp-commands.hx | 7 ++++--- > 3 files changed, 11 insertions(+), 6 deletions(-) > > diff --git a/hmp-commands.hx b/hmp-commands.hx > index 4befbe2..0071409 100644 > --- a/hmp-commands.hx > +++ b/hmp-commands.hx > @@ -735,13 +735,14 @@ ETEXI > > { > .name = "migrate", > - .args_type = "detach:-d,blk:-b,inc:-i,uri:s", > - .params = "[-d] [-b] [-i] uri", > + .args_type = "detach:-d,blk:-b,inc:-i,ft:-k,uri:s", > + .params = "[-d] [-b] [-i] [-k] uri", > .help = "migrate to URI (using -d to not wait for completion)" > "\n\t\t\t -b for migration without shared storage with" > " full copy of disk\n\t\t\t -i for migration without " > "shared storage with incremental copy of disk " > - "(base image shared between src and destination)", > + "(base image shared between src and destination)" > + "\n\t\t\t -k for FT migration mode (Kemari)", FT -> Fault tolerance? IMO it's preferrable to avoid abbreviations in the documentation. Not sure whether we need to mention the codename here: is it likely to help the users? > .user_print = monitor_user_noop, > .mhandler.cmd_new = do_migrate, > }, > diff --git a/migration.c b/migration.c > index 0db0b6d..a4a39eb 100644 > --- a/migration.c > +++ b/migration.c > @@ -92,6 +92,9 @@ int do_migrate(Monitor *mon, const QDict *qdict, QObject **ret_data) > return -1; > } > > + if (qdict_get_try_bool(qdict, "ft", 0)) > + ft_mode = FT_INIT; > + > if (strstart(uri, "tcp:", &p)) { > s = tcp_start_outgoing_migration(mon, p, max_throttle, detach, > blk, inc); > diff --git a/qmp-commands.hx b/qmp-commands.hx > index 3486223..b28bf70 100644 > --- a/qmp-commands.hx > +++ b/qmp-commands.hx > @@ -431,13 +431,14 @@ EQMP > > { > .name = "migrate", > - .args_type = "detach:-d,blk:-b,inc:-i,uri:s", > - .params = "[-d] [-b] [-i] uri", > + .args_type = "detach:-d,blk:-b,inc:-i,ft:-k,uri:s", > + .params = "[-d] [-b] [-i] [-k] uri", > .help = "migrate to URI (using -d to not wait for completion)" > "\n\t\t\t -b for migration without shared storage with" > " full copy of disk\n\t\t\t -i for migration without " > "shared storage with incremental copy of disk " > - "(base image shared between src and destination)", > + "(base image shared between src and destination)" > + "\n\t\t\t -k for FT migration mode (Kemari)", > .user_print = monitor_user_noop, > .mhandler.cmd_new = do_migrate, > }, > -- > 1.7.1.2