From: Gleb Natapov <gleb@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Avi Kivity <avi@redhat.com>, Huang Ying <ying.huang@intel.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
Andi Kleen <andi@firstfloor.org>,
Dean Nelson <dnelson@redhat.com>
Subject: Re: QEMU, MCE, unpoison memory address across reboot
Date: Tue, 28 Dec 2010 10:27:09 +0200 [thread overview]
Message-ID: <20101228082709.GT2231@redhat.com> (raw)
In-Reply-To: <20101227212754.GB13518@amt.cnet>
On Mon, Dec 27, 2010 at 07:27:54PM -0200, Marcelo Tosatti wrote:
> On Sun, Dec 26, 2010 at 02:27:26PM +0200, Avi Kivity wrote:
> > >> +static void kvm_unpoison_all(void *param)
> > >> +{
> > >> + HWPoisonPage *page, *next_page;
> > >> + unsigned long address;
> > >> + KVMState *s = param;
> > >> +
> > >> + QLIST_FOREACH_SAFE(page,&hwpoison_page_list, list, next_page) {
> > >> + address = (unsigned long)page->vaddr;
> > >> + QLIST_REMOVE(page, list);
> > >> + kvm_vm_ioctl(s, KVM_UNPOISON_ADDRESS, address);
> > >> + qemu_free(page);
> > >> + }
> > >> +}
> > >
> > >Can't you free and reallocate all guest memory instead, on reboot, if
> > >there's a hwpoisoned page? Then you don't need this interface.
> > >
> >
> > Alternatively, MADV_DONTNEED? We already use it for ballooning.
>
> Does not work for hugetlbfs.
>
Don't we break huge page to 4k pages during poisoning?
--
Gleb.
next prev parent reply other threads:[~2010-12-28 8:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-22 2:52 QEMU, MCE, unpoison memory address across reboot Huang Ying
2010-12-23 14:28 ` Marcelo Tosatti
2010-12-23 16:57 ` Andi Kleen
2010-12-24 1:21 ` Huang Ying
2010-12-24 3:30 ` Huang Ying
2010-12-27 21:27 ` Marcelo Tosatti
2010-12-26 12:27 ` Avi Kivity
2010-12-27 21:27 ` Marcelo Tosatti
2010-12-28 6:18 ` Huang Ying
2010-12-28 8:11 ` Avi Kivity
2010-12-28 8:32 ` Huang Ying
2010-12-28 9:05 ` Avi Kivity
2010-12-28 8:27 ` Gleb Natapov [this message]
2010-12-28 8:35 ` Huang Ying
2010-12-28 9:06 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101228082709.GT2231@redhat.com \
--to=gleb@redhat.com \
--cc=andi@firstfloor.org \
--cc=avi@redhat.com \
--cc=dnelson@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox