From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: QEMU, MCE, unpoison memory address across reboot
Date: Tue, 28 Dec 2010 10:27:09 +0200
Message-ID: <20101228082709.GT2231@redhat.com>
References: <1292986371.8743.113.camel@yhuang-dev>
 <20101223142803.GD17819@amt.cnet>
 <4D1734AE.30909@redhat.com>
 <20101227212754.GB13518@amt.cnet>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Avi Kivity <avi@redhat.com>, Huang Ying <ying.huang@intel.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	Andi Kleen <andi@firstfloor.org>,
	Dean Nelson <dnelson@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:64473 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751102Ab0L1I1O (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 28 Dec 2010 03:27:14 -0500
Content-Disposition: inline
In-Reply-To: <20101227212754.GB13518@amt.cnet>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Mon, Dec 27, 2010 at 07:27:54PM -0200, Marcelo Tosatti wrote:
> On Sun, Dec 26, 2010 at 02:27:26PM +0200, Avi Kivity wrote:
> > >>  +static void kvm_unpoison_all(void *param)
> > >>  +{
> > >>  +    HWPoisonPage *page, *next_page;
> > >>  +    unsigned long address;
> > >>  +    KVMState *s = param;
> > >>  +
> > >>  +    QLIST_FOREACH_SAFE(page,&hwpoison_page_list, list, next_page) {
> > >>  +        address = (unsigned long)page->vaddr;
> > >>  +        QLIST_REMOVE(page, list);
> > >>  +        kvm_vm_ioctl(s, KVM_UNPOISON_ADDRESS, address);
> > >>  +        qemu_free(page);
> > >>  +    }
> > >>  +}
> > >
> > >Can't you free and reallocate all guest memory instead, on reboot, if
> > >there's a hwpoisoned page? Then you don't need this interface.
> > >
> > 
> > Alternatively, MADV_DONTNEED?  We already use it for ballooning.
> 
> Does not work for hugetlbfs.
> 
Don't we break huge page to 4k pages during poisoning?

--
			Gleb.