From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH] Add ability to drop pages through testdev Date: Wed, 29 Dec 2010 11:55:52 +0200 Message-ID: <20101229095552.GC32688@redhat.com> References: <20101222151849.GF2231@redhat.com> <4D1B0478.5010304@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: mtosatti@redhat.com, kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:50637 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751001Ab0L2Jzy (ORCPT ); Wed, 29 Dec 2010 04:55:54 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oBT9ts4t008762 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 29 Dec 2010 04:55:54 -0500 Content-Disposition: inline In-Reply-To: <4D1B0478.5010304@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Wed, Dec 29, 2010 at 11:50:48AM +0200, Avi Kivity wrote: > On 12/22/2010 05:18 PM, Gleb Natapov wrote: > >Signed-off-by: Gleb Natapov > >diff --git a/hw/testdev.c b/hw/testdev.c > >index d1abf59..29df385 100644 > >--- a/hw/testdev.c > >+++ b/hw/testdev.c > >@@ -1,3 +1,4 @@ > >+#include > > #include "hw.h" > > #include "qdev.h" > > #include "isa.h" > >@@ -46,6 +47,16 @@ static uint32_t test_device_ioport_read(void *opaque, uint32_t addr) > > return test_device_ioport_data; > > } > > > >+static void test_device_flush_page(void *opaque, uint32_t addr, uint32_t data) > >+{ > >+ target_phys_addr_t len = 4096; > >+ void *a = cpu_physical_memory_map(data& ~0xffful,&len, 0); > >+ > >+ mprotect(a, 4096, PROT_NONE); > >+ mprotect(a, 4096, PROT_READ|PROT_WRITE); > >+ cpu_physical_memory_unmap(a, len, 0, 0); > >+} > >+ > > Icky. This is much better done through the api tests. Applied it > so as not to spoil all the effort. > How would you do that there? -- Gleb.