From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] Re: [PATCH v3] qemu, qmp: convert do_inject_nmi()
 to QObject, QError
Date: Mon, 3 Jan 2011 11:46:52 -0200
Message-ID: <20110103114652.23e49d02@doriath>
References: <4D088F27.8000909@cn.fujitsu.com>
	<20101215150911.14e1693f@doriath>
	<4D08F868.5090100@redhat.com>
	<20101215152606.078147ad@doriath>
	<m3aak7ylp6.fsf@blackfin.pond.sub.org>
	<20101215160000.16f85795@doriath>
	<4D09D5EA.7070000@redhat.com>
	<20101216084815.3ca77188@doriath>
	<m3oc8mj5wm.fsf@blackfin.pond.sub.org>
	<4D0A0B00.3070108@redhat.com>
	<20101216110917.646779b7@doriath>
	<4D0A1016.7060408@redhat.com>
	<20101216111752.77757c00@doriath>
	<4D0B011F.8060502@cn.fujitsu.com>
	<20101217092234.0e43101d@doriath>
	<4D0B80E2.4070307@redhat.com>
	<4D0EF301.8040903@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: Avi Kivity <avi@redhat.com>, Markus Armbruster <armbru@redhat.com>,
	qemu-devel@nongnu.org, aliguori@us.ibm.com, kvm@vger.kernel.org
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:21893 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754503Ab1ACNrE (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 3 Jan 2011 08:47:04 -0500
In-Reply-To: <4D0EF301.8040903@cn.fujitsu.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Mon, 20 Dec 2010 14:09:05 +0800
Lai Jiangshan <laijs@cn.fujitsu.com> wrote:

> On 12/17/2010 11:25 PM, Avi Kivity wrote:
> > On 12/17/2010 01:22 PM, Luiz Capitulino wrote:
> >> >
> >> >  I think Avi's suggest is better, and I will use
> >> >  "inject-nmi" (without cpu-index argument) to send NMI to all cpus,
> >> >  like physical GUI. If some one want to send NMI to a set of cpus,
> >> >  he can use "inject-nmi" multiple times.
> >>
> >> His suggestion is to drop _all_ arguments, right Avi?
> > 
> > Yes.
> > 
> 
> We don't need to drop the cpu-index argument,
> the upstream tools(libvirt etc.) can just issue "inject-nmi"
> command without any argument when need.
> 
> Reasons to keep this argument
> 1) Useful for kernel developer or debuger sending NMI to a special CPU.

Ok.

> 2) Share the code with nmi of hmp version. Share the way how to
>    use these two commands.(hmp version and qmp version)

This is bad. As a general rule, we shouldn't tweak QMP interfaces with
the intention of sharing code with HMP or anything like that.

Anyway, I buy your first argument, although I'm not a kernel developer
so I'm just trusting your use case.