Re: [Qemu-devel] [PATCH 00/21] Kemari for KVM 0.2

Anthony Liguori
2010-11-29T17:33:59Z

On 11/29/2010 11:18 AM, Paul Brook wrote:
>> On 11/29/2010 10:53 AM, Paul Brook wrote:
>>
>>>>> Is this a fair summary: any device that supports live migration workw
>>>>> under Kemari?
>>>>>
>>>> It might be fair summary but practically we barely have live migration
>>>> working w/o Kemari. In addition, last I checked Kemari needs additional
>>>> hooks and it will be too hard to keep that out of tree until all devices
>>>> get it.
>>>>
>>> That's not what I've been hearing earlier in this thread.
>>> The responses from Yoshi indicate that Stefan's summary is correct. i.e.
>>> the current Kemari implementation may require per-device hooks, but
>>> that's a bug and should be fixed before merging.
>>>
>> It's actually really important that Kemari make use of an intermediate
>> layer such that the hooks can distinguish between a device access and a
>> recursive access.
>>
> I'm failing to understand how this is anything other than running sed over
> block/*.c (or hw/*.c, depending whether you choose to rename the internal or
> external API).
>

You're right, it's not a big deal, and requiring everything in hw use
the new interface is not a bad idea.

If a device doesn't work with Kemari, that's okay as long as the
non-Kemari case is essentially a nop.

Regards,

Anthony Liguori

> Paul
>