From mboxrd@z Thu Jan 1 00:00:00 1970 From: "aurelien@aurel32.net" Subject: Re: Qemu-kvm Build fail with function 'cirrus_bitblt_start' on RHEL5 system Date: Mon, 10 Jan 2011 07:17:23 +0100 Message-ID: <20110110061723.GD17026@hall.aurel32.net> References: Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Cc: "kvm@vger.kernel.org" , Avi Kivity To: "Hao, Xudong" Return-path: Received: from hall.aurel32.net ([88.191.126.93]:58104 "EHLO hall.aurel32.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751066Ab1AJGsG (ORCPT ); Mon, 10 Jan 2011 01:48:06 -0500 Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Jan 10, 2011 at 10:05:17AM +0800, Hao, Xudong wrote: > Qemu-kvm commit 92d675d1c1f23f3617e24b63c825074a1d1da44b changed sx, dx and others variables into a judgement, there was a build failure on RHEL5 system. > > ... > CC x86_64-softmmu/debugcon.o > cc1: warnings being treated as errors > /workspace/ia32-pae/nightly/qemu-kvm/hw/cirrus_vga.c: In function 'cirrus_bitblt_start': > /workspace/ia32-pae/nightly/qemu-kvm/hw/cirrus_vga.c:678: warning: 'dx' may be used uninitialized in this function > /workspace/ia32-pae/nightly/qemu-kvm/hw/cirrus_vga.c:677: warning: 'sx' may be used uninitialized in this function > /workspace/ia32-pae/nightly/qemu-kvm/hw/cirrus_vga.c:679: warning: 'depth' may be used uninitialized in this function > /workspace/ia32-pae/nightly/qemu-kvm/hw/cirrus_vga.c:678: warning: 'dy' may be used uninitialized in this function > /workspace/ia32-pae/nightly/qemu-kvm/hw/cirrus_vga.c:677: warning: 'sy' may be used uninitialized in this function > CC x86_64-softmmu/multiboot.o > make[1]: *** [cirrus_vga.o] Error 1 > make[1]: *** Waiting for unfinished jobs.... > make: *** [subdir-x86_64-softmmu] Error 2 > Yes, the code is correct, but some compilers choke on that, some not. Anyway it's fixed in 78935c4a4bfec8ef2f4f924cfc35ac09a963e81e. Aurelien -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net