From mboxrd@z Thu Jan 1 00:00:00 1970 From: Amos Kong Subject: Re: [Autotest] [PATCH] KVM test: Fix typos in ethtool Date: Mon, 10 Jan 2011 15:17:14 +0800 Message-ID: <20110110071714.GA3978@t400> References: <1294413669-5497-1-git-send-email-lmr@redhat.com> Reply-To: Amos Kong Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Cc: autotest@test.kernel.org, kvm@vger.kernel.org To: Lucas Meneghel Rodrigues Return-path: Received: from mx1.redhat.com ([209.132.183.28]:11220 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751292Ab1AJHRS (ORCPT ); Mon, 10 Jan 2011 02:17:18 -0500 Content-Disposition: inline In-Reply-To: <1294413669-5497-1-git-send-email-lmr@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Jan 07, 2011 at 01:21:09PM -0200, Lucas Meneghel Rodrigues wrote: > Signed-off-by: Lucas Meneghel Rodrigues > --- > client/tests/kvm/tests/ethtool.py | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/client/tests/kvm/tests/ethtool.py b/client/tests/kvm/tests/ethtool.py > index 011df29..9708497 100644 > --- a/client/tests/kvm/tests/ethtool.py > +++ b/client/tests/kvm/tests/ethtool.py > @@ -104,11 +104,11 @@ def run_ethtool(test, params, env): > if src == "guest": > session.cmd_output(dd_cmd, timeout=360) > tcpdump_cmd += " and src %s" % guest_ip > - copy_files_fun = vm.copy_files_from > + copy_files_from = vm.copy_files_from > else: > s, o = commands.getstatusoutput(dd_cmd) > tcpdump_cmd += " and dst %s" % guest_ip > - copy_files_fun = vm.copy_files_to > + copy_files_from = vm.copy_files_to > if s != 0: > return (False, "Fail to create file by dd, cmd: %s" % dd_cmd) > > @@ -125,7 +125,7 @@ def run_ethtool(test, params, env): > > logging.info("Start to transfer file") > try: > - copy_files_fun(filename, filename): > + copy_files_from(filename, filename) Does this patch base on a wrong fix ? there is no 'copy_files_fun(filename, filename):' in original ethtool.py Current ethtool.py also exists an typo, will send a patch to fix this. > except kvm_utils.SCPError, e: > return (False, "File transfer failed (%s)" % e) > logging.info("Transfer file completed") > -- > 1.7.3.4 > > _______________________________________________ > Autotest mailing list > Autotest@test.kernel.org > http://test.kernel.org/cgi-bin/mailman/listinfo/autotest