From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH unit-tests 3/3] Test that vcpu does not continue to run
 after issuing S3.
Date: Tue, 11 Jan 2011 16:17:43 +0200
Message-ID: <20110111141743.GC14750@redhat.com>
References: <1294752607-7920-1-git-send-email-gleb@redhat.com>
 <1294752607-7920-3-git-send-email-gleb@redhat.com>
 <4D2C60C4.1070100@redhat.com>
 <20110111135433.GB14750@redhat.com>
 <4D2C6455.7050609@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: mtosatti@redhat.com, kvm@vger.kernel.org
To: Avi Kivity <avi@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:24870 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753621Ab1AKORp (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 11 Jan 2011 09:17:45 -0500
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id p0BEHimN025121
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <kvm@vger.kernel.org>; Tue, 11 Jan 2011 09:17:45 -0500
Content-Disposition: inline
In-Reply-To: <4D2C6455.7050609@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, Jan 11, 2011 at 04:08:21PM +0200, Avi Kivity wrote:
> On 01/11/2011 03:54 PM, Gleb Natapov wrote:
> >On Tue, Jan 11, 2011 at 03:53:08PM +0200, Avi Kivity wrote:
> >>  On 01/11/2011 03:30 PM, Gleb Natapov wrote:
> >>  >+
> >>  >+asm (
> >>  >+        ".global resume_start\n"
> >>  >+	".global resume_end\n"
> >>  >+	".code16\n"
> >>  >+	"resume_start:\n"
> >>  >+	"mov 0x0, %eax\n"
> >>  >+	"mov $0xf4, %dx\n"
> >>  >+	"out %eax, %dx\n"
> >>  >+	"1: hlt\n"
> >>  >+	"jmp 1b\n"
> >>  >+	"resume_end:\n"
> >>  >+#ifdef __i386__
> >>  >+	".code32\n"
> >>  >+#else
> >>  >+	".code64\n"
> >>  >+#endif
> >>  >+    );
> >>
> >>  Is this a kvm unit test or a qemu unit test?
> >>
> >Both? Is this a bad thing?
> 
> We may want to move non-kvm tests to qemu.git.  Though all of the
> non-api tests work equally for qemu and kvm.
> 
We will have to maintain two separate unit test infrastructures then.
We can make x86/qemu or x86/device-model subdir in kvm-unit-test.

--
			Gleb.